When DWM compositing is disabled (i.e. XP, RDP) ensure that windowed NPAPI plugins don't cover UI d…

When DWM compositing is disabled (i.e. XP, RDP) ensure that windowed NPAPI plugins don't cover UI dialogs. This includes things like omnibox, star window, profile selector, and bookmark editor.

The solution is to start watching the root window as well as the parent window.
BUG=299224
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234708

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234823

[Ben Goodger (Google), 2013-11-12 02:41:43]

https://codereview.chromium.org/69833002/diff/1/chrome/browser/ui/views/locat...
File chrome/browser/ui/views/location_bar/star_view_browsertest.cc (right):

https://codereview.chromium.org/69833002/diff/1/chrome/browser/ui/views/locat...
chrome/browser/ui/views/location_bar/star_view_browsertest.cc:126:
star_view->OnMousePressed(pressed_event);
I know it may be tempting just to do this, but it bypasses various state
collection in RootView etc. and is basically unsupported.

I would #include "ui/base/test/ui_controls.h" instead and move the cursor to the
CenterPoint of this view's bounds, and send a click from there using the utility
functions in that file.

[jam, 2013-11-12 02:53:58]

https://codereview.chromium.org/69833002/diff/1/chrome/browser/ui/views/locat...
File chrome/browser/ui/views/location_bar/star_view_browsertest.cc (right):

https://codereview.chromium.org/69833002/diff/1/chrome/browser/ui/views/locat...
chrome/browser/ui/views/location_bar/star_view_browsertest.cc:126:
star_view->OnMousePressed(pressed_event);
On 2013/11/12 02:41:44, Ben Goodger (Google) wrote:
> I know it may be tempting just to do this, but it bypasses various state
> collection in RootView etc. and is basically unsupported.
> 
> I would #include "ui/base/test/ui_controls.h" instead and move the cursor to
the
> CenterPoint of this view's bounds, and send a click from there using the
utility
> functions in that file.

I just copied this from the above test. I could change this, but I'm not
familiar with this code and its history, so I'm not sure if this was done to be
less flaky etc. how strongly do you feel about this?

[jam, 2013-11-12 18:17:03]

hmm, test flaked so I rewrote it and i'm sending a bunch of tries, ptal

[Ben Goodger (Google), 2013-11-12 18:30:29]

lgtm