Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 698293002: ozone: Add PRESUBMIT.py to check patch formatting (Closed)

Created:
6 years, 1 month ago by spang
Modified:
6 years, 1 month ago
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ozone: Add PRESUBMIT.py to check patch formatting Committed: https://crrev.com/fd07201fce5cdf8147ec50e98a3eb283acabeee1 Cr-Commit-Position: refs/heads/master@{#302638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -165 lines) Patch
A + ui/ozone/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/demo/ozone_demo.cc View 1 chunk +10 lines, -12 lines 0 comments Download
M ui/ozone/gpu/gpu_memory_buffer_factory_ozone_native_buffer.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M ui/ozone/platform/caca/caca_window.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/crtc_controller.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M ui/ozone/platform/dri/display_snapshot_dri.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/ozone/platform/dri/dri_cursor.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M ui/ozone/platform/dri/dri_gpu_platform_support.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/ozone/platform/dri/dri_gpu_platform_support_host.cc View 2 chunks +8 lines, -12 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface_factory.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M ui/ozone/platform/dri/dri_surface_factory_unittest.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M ui/ozone/platform/dri/dri_window.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/dri_window_delegate_impl.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M ui/ozone/platform/dri/dri_wrapper.cc View 1 chunk +1 line, -5 lines 0 comments Download
M ui/ozone/platform/dri/gbm_buffer.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/ozone/platform/dri/hardware_display_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/ozone/platform/dri/hardware_display_controller_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/native_display_delegate_dri.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/native_display_delegate_dri.cc View 7 chunks +12 lines, -19 lines 0 comments Download
M ui/ozone/platform/dri/native_display_delegate_proxy.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/ozone/platform/dri/native_display_delegate_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_dri.cc View 2 chunks +5 lines, -10 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_gbm.cc View 2 chunks +6 lines, -11 lines 0 comments Download
M ui/ozone/platform/dri/screen_manager.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ui/ozone/platform/dri/screen_manager_unittest.cc View 8 chunks +29 lines, -30 lines 0 comments Download
M ui/ozone/platform/egltest/ozone_platform_egltest.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
spang
6 years, 1 month ago (2014-11-04 16:41:05 UTC) #2
alexst (slow to review)
lgtm
6 years, 1 month ago (2014-11-04 16:48:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698293002/1
6 years, 1 month ago (2014-11-04 16:49:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 19:11:26 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 19:13:39 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fd07201fce5cdf8147ec50e98a3eb283acabeee1
Cr-Commit-Position: refs/heads/master@{#302638}

Powered by Google App Engine
This is Rietveld 408576698