Issue 698283003: Record ConnectionType metrics in OpenSSL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 698283003: Record ConnectionType metrics in OpenSSL. (Closed)

Created:
6 years, 1 month ago by davidben

Modified:
6 years, 1 month ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Record ConnectionType metrics in OpenSSL. They were being recorded on the NSS side, but not the OpenSSL side. BUG=430313 Committed: https://crrev.com/7c7ab60a820438fcc5b05f0f3dd9f507f87a1c82 Cr-Commit-Position: refs/heads/master@{#302888}

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -28 lines)			Patch
M	net/socket/ssl_client_socket.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/socket/ssl_client_socket.cc	View	2 chunks	+24 lines, -0 lines	0 comments	Download
M	net/socket/ssl_client_socket_nss.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/socket/ssl_client_socket_nss.cc	View	3 chunks	+5 lines, -26 lines	0 comments	Download
M	net/socket/ssl_client_socket_openssl.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698283003/1

6 years, 1 month ago (2014-11-05 20:52:56 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-05 22:28:34 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/7c7ab60a820438fcc5b05f0f3dd9f507f87a1c82
Cr-Commit-Position: refs/heads/master@{#302888}