Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Issue 698273003: Use MediaFormat's crop rectangle when available instead of width/height. (Closed)

Created:
6 years, 1 month ago by gunsch
Modified:
6 years, 1 month ago
Reviewers:
qinmin
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use MediaFormat's crop rectangle when available instead of width/height. Per Android media team, width/height is not always reliable. See: https://github.com/google/ExoPlayer/blob/a7b88cd6a9bac4de5ef47b23e0d7fb50c570b3a6/library/src/main/java/com/google/android/exoplayer/MediaCodecVideoTrackRenderer.java#L319 R=qinmin@chromium.org BUG=internal b/18224769 Committed: https://crrev.com/357d1f8cc2c53eebafa512b258acd6b18d0c44ab Cr-Commit-Position: refs/heads/master@{#302739}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -4 lines) Patch
M media/base/android/java/src/org/chromium/media/MediaCodecBridge.java View 3 chunks +20 lines, -4 lines 3 comments Download

Messages

Total messages: 9 (1 generated)
gunsch
6 years, 1 month ago (2014-11-05 00:04:28 UTC) #1
gunsch
Verified this change on both: 1) https://www.youtube.com/watch?v=MJ62hh0a9U4 2) https://www.youtube.com/watch?v=tmeOjFno6Do https://codereview.chromium.org/698273003/diff/1/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java File media/base/android/java/src/org/chromium/media/MediaCodecBridge.java (right): https://codereview.chromium.org/698273003/diff/1/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java#newcode253 media/base/android/java/src/org/chromium/media/MediaCodecBridge.java:253: ...
6 years, 1 month ago (2014-11-05 00:05:51 UTC) #2
qinmin
https://codereview.chromium.org/698273003/diff/1/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java File media/base/android/java/src/org/chromium/media/MediaCodecBridge.java (right): https://codereview.chromium.org/698273003/diff/1/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java#newcode253 media/base/android/java/src/org/chromium/media/MediaCodecBridge.java:253: MediaCodecInfo.CodecCapabilities capabilities = info.getCapabilitiesForType(mime); On 2014/11/05 00:05:51, gunsch wrote: ...
6 years, 1 month ago (2014-11-05 00:28:00 UTC) #3
gunsch
https://codereview.chromium.org/698273003/diff/1/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java File media/base/android/java/src/org/chromium/media/MediaCodecBridge.java (right): https://codereview.chromium.org/698273003/diff/1/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java#newcode253 media/base/android/java/src/org/chromium/media/MediaCodecBridge.java:253: MediaCodecInfo.CodecCapabilities capabilities = info.getCapabilitiesForType(mime); On 2014/11/05 00:28:00, qinmin wrote: ...
6 years, 1 month ago (2014-11-05 00:31:44 UTC) #4
qinmin
On 2014/11/05 00:31:44, gunsch wrote: > https://codereview.chromium.org/698273003/diff/1/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java > File media/base/android/java/src/org/chromium/media/MediaCodecBridge.java > (right): > > https://codereview.chromium.org/698273003/diff/1/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java#newcode253 ...
6 years, 1 month ago (2014-11-05 00:36:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698273003/1
6 years, 1 month ago (2014-11-05 01:12:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-05 01:53:45 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 01:55:21 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/357d1f8cc2c53eebafa512b258acd6b18d0c44ab
Cr-Commit-Position: refs/heads/master@{#302739}

Powered by Google App Engine
This is Rietveld 408576698