Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 698263003: [chrome/common/renderer/media && chrome/common/renderer/safe_browsing] Convert VLOGs to DVLOGs (Closed)

Created:
6 years, 1 month ago by anujsharma
Modified:
6 years, 1 month ago
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, grt+watch_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[chrome/common/renderer/media && chrome/common/renderer/safe_browsing] Convert VLOGs to DVLOGs BUG=101424 TBR=hclam@chromium.org Committed: https://crrev.com/6ce2f789466874f91cb5fe2834745018a2567a2a Cr-Commit-Position: refs/heads/master@{#303804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M chrome/renderer/media/cast_rtp_stream.cc View 6 chunks +12 lines, -12 lines 0 comments Download
M chrome/renderer/media/cast_session_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/media/cast_udp_transport.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate.cc View 5 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 23 (7 generated)
anujsharma
mattm@chromium.org: Please review changes in safe_browsing module xhwang@chromium.org: Please review changes in media module
6 years, 1 month ago (2014-11-11 13:25:59 UTC) #2
xhwang
hclam: Please review chrome/renderer/media/cast_*
6 years, 1 month ago (2014-11-11 17:16:19 UTC) #4
miu
media/cast lgtm
6 years, 1 month ago (2014-11-11 18:08:44 UTC) #6
mattm
safe_browsing lgtm
6 years, 1 month ago (2014-11-11 21:55:49 UTC) #7
anujsharma
Thanks miu and mattm for lgtm. But it seems still i need lgtm for renderer/media.
6 years, 1 month ago (2014-11-12 02:41:30 UTC) #8
miu
On 2014/11/12 02:41:30, anujsharma wrote: > Thanks miu and mattm for lgtm. > But it ...
6 years, 1 month ago (2014-11-12 06:47:55 UTC) #9
anujsharma
On 2014/11/12 06:47:55, miu wrote: > On 2014/11/12 02:41:30, anujsharma wrote: > > Thanks miu ...
6 years, 1 month ago (2014-11-12 06:51:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698263003/1
6 years, 1 month ago (2014-11-12 06:52:28 UTC) #12
anujsharma
On 2014/11/12 06:51:05, anujsharma wrote: > On 2014/11/12 06:47:55, miu wrote: > > On 2014/11/12 ...
6 years, 1 month ago (2014-11-12 06:52:37 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/23633)
6 years, 1 month ago (2014-11-12 06:55:37 UTC) #15
miu
On 2014/11/12 06:51:05, anujsharma wrote: > On 2014/11/12 06:47:55, miu wrote: > > On 2014/11/12 ...
6 years, 1 month ago (2014-11-12 07:05:02 UTC) #16
anujsharma
On 2014/11/12 07:05:02, miu wrote: > On 2014/11/12 06:51:05, anujsharma wrote: > > On 2014/11/12 ...
6 years, 1 month ago (2014-11-12 07:06:23 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698263003/1
6 years, 1 month ago (2014-11-12 07:06:32 UTC) #20
anujsharma
On 2014/11/12 07:05:02, miu wrote: > On 2014/11/12 06:51:05, anujsharma wrote: > > On 2014/11/12 ...
6 years, 1 month ago (2014-11-12 07:07:45 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-12 08:04:35 UTC) #22
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 08:05:21 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ce2f789466874f91cb5fe2834745018a2567a2a
Cr-Commit-Position: refs/heads/master@{#303804}

Powered by Google App Engine
This is Rietveld 408576698