ui/views/touchui/touch_editing_menu.cc - Issue 698253004: Reland: Implement Aura side of unified touch text selection for contents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/touchui/touch_editing_menu.cc

Issue 698253004: Reland: Implement Aura side of unified touch text selection for contents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased after addition of touch_handle_orientation file Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ui/touch_selection/touch_selection_controller_aura.cc ('K') | « ui/views/DEPS ('k') | ui/views/touchui/touch_selection_menu_runner_views.h » ('j') | ui/views/touchui/touch_selection_menu_runner_views.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/touchui/touch_editing_menu.cc

diff --git a/ui/views/touchui/touch_editing_menu.cc b/ui/views/touchui/touch_editing_menu.cc

index 7b2c5b61acfc2f7b82a2de626e8b7ab46d5922e8..5ee444388f7b94ccd3970962d657110cac4afd50 100644

--- a/ui/views/touchui/touch_editing_menu.cc

+++ b/ui/views/touchui/touch_editing_menu.cc

@@ -58,6 +58,11 @@ TouchEditingMenuView::TouchEditingMenuView(

// menu is needed to be shown under the selection.

gfx::Rect adjusted_anchor_rect(anchor_rect);

int menu_width = GetPreferredSize().width();

+ // TODO(mfomitchev): This assumes that the handles are center-aligned to the

+ // achor_rect edges, which is not true. We should fix this, perhaps by passing

+ // down the cumulative width occupied by the handles within anchor_rect plus

+ // the handle image height instead of |handle_image_size|. Perhaps we should

+ // also allow for some minimum padding.

if (menu_width > anchor_rect.width() - handle_image_size.width())

adjusted_anchor_rect.Inset(0, 0, 0, -handle_image_size.height());

SetAnchorRect(adjusted_anchor_rect);