Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: content/browser/web_contents/web_contents_view_aura.cc

Issue 698253004: Reland: Implement Aura side of unified touch text selection for contents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed overrides in TouchHandleDrawableAura Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_view_aura.cc
diff --git a/content/browser/web_contents/web_contents_view_aura.cc b/content/browser/web_contents/web_contents_view_aura.cc
index 5b976ba1921edda335408986df99d93983e48370..19c56cba00a19504cccc30a4490724b6156d0584 100644
--- a/content/browser/web_contents/web_contents_view_aura.cc
+++ b/content/browser/web_contents/web_contents_view_aura.cc
@@ -21,11 +21,10 @@
#include "content/browser/renderer_host/render_widget_host_view_aura.h"
#include "content/browser/renderer_host/web_input_event_aura.h"
#include "content/browser/web_contents/aura/gesture_nav_simple.h"
-#include "content/browser/web_contents/aura/image_window_delegate.h"
#include "content/browser/web_contents/aura/overscroll_navigation_overlay.h"
#include "content/browser/web_contents/aura/shadow_layer_delegate.h"
#include "content/browser/web_contents/aura/window_slider.h"
-#include "content/browser/web_contents/touch_editable_impl_aura.h"
+#include "content/browser/web_contents/touch_selection_controller_aura_client_impl.h"
#include "content/browser/web_contents/web_contents_impl.h"
#include "content/public/browser/content_browser_client.h"
#include "content/public/browser/notification_observer.h"
@@ -48,6 +47,7 @@
#include "ui/aura/client/aura_constants.h"
#include "ui/aura/client/window_tree_client.h"
#include "ui/aura/env.h"
+#include "ui/aura/image_window_delegate.h"
#include "ui/aura/window.h"
#include "ui/aura/window_observer.h"
#include "ui/aura/window_tree_host.h"
@@ -68,6 +68,7 @@
#include "ui/gfx/image/image_png_rep.h"
#include "ui/gfx/image/image_skia.h"
#include "ui/gfx/screen.h"
+#include "ui/touch_selection/touch_selection_controller_aura.h"
#include "ui/wm/public/drag_drop_client.h"
#include "ui/wm/public/drag_drop_delegate.h"
@@ -116,7 +117,7 @@ RenderWidgetHostViewAura* ToRenderWidgetHostViewAura(
// The window delegate for the overscroll window. This redirects trackpad events
// to the web-contents window. The delegate destroys itself when the window is
// destroyed.
-class OverscrollWindowDelegate : public ImageWindowDelegate {
+class OverscrollWindowDelegate : public aura::ImageWindowDelegate {
public:
OverscrollWindowDelegate(WebContentsImpl* web_contents,
OverscrollMode overscroll_mode)
@@ -618,8 +619,12 @@ class WebContentsViewAura::WindowObserver
const gfx::Rect& new_bounds) override {
if (window == host_window_ || window == view_->window_) {
SendScreenRects();
- if (view_->touch_editable_)
- view_->touch_editable_->UpdateEditingController();
+ if (old_bounds.origin() != new_bounds.origin()) {
+ ui::TouchSelectionControllerAura* selection_controller =
+ view_->GetSelectionController();
+ if (selection_controller)
+ selection_controller->OnWindowMoved();
+ }
#if defined(OS_WIN)
} else {
UpdateConstrainedWindows(NULL);
@@ -738,7 +743,6 @@ WebContentsViewAura::WebContentsViewAura(
overscroll_change_brightness_(false),
current_overscroll_gesture_(OVERSCROLL_NONE),
completed_overscroll_gesture_(OVERSCROLL_NONE),
- touch_editable_(TouchEditableImplAura::Create()),
is_or_was_visible_(false) {
}
@@ -757,12 +761,6 @@ WebContentsViewAura::~WebContentsViewAura() {
window_.reset();
}
-void WebContentsViewAura::SetTouchEditableForTest(
- TouchEditableImplAura* touch_editable) {
- touch_editable_.reset(touch_editable);
- AttachTouchEditableToRenderView();
-}
-
void WebContentsViewAura::SizeChangedCommon(const gfx::Size& size) {
if (web_contents_->GetInterstitialPage())
web_contents_->GetInterstitialPage()->SetSize(size);
@@ -976,20 +974,21 @@ void WebContentsViewAura::UpdateOverscrollWindowBrightness(float delta_x) {
window->layer()->SetLayerBrightness(brightness);
}
-void WebContentsViewAura::AttachTouchEditableToRenderView() {
- if (!touch_editable_)
- return;
- RenderWidgetHostViewAura* rwhva = ToRenderWidgetHostViewAura(
- web_contents_->GetRenderWidgetHostView());
- touch_editable_->AttachToView(rwhva);
-}
-
void WebContentsViewAura::OverscrollUpdateForWebContentsDelegate(
float delta_y) {
if (web_contents_->GetDelegate() && IsScrollEndEffectEnabled())
web_contents_->GetDelegate()->OverscrollUpdate(delta_y);
}
+ui::TouchSelectionControllerAura*
+WebContentsViewAura::GetSelectionController() {
+ RenderWidgetHostViewAura* view =
+ ToRenderWidgetHostViewAura(web_contents_->GetRenderWidgetHostView());
+ if (!view)
+ return nullptr;
+ return view->selection_controller();
+}
+
////////////////////////////////////////////////////////////////////////////////
// WebContentsViewAura, WebContentsView implementation:
@@ -1129,6 +1128,10 @@ RenderWidgetHostViewBase* WebContentsViewAura::CreateViewForWidget(
RenderWidgetHostViewAura* view =
new RenderWidgetHostViewAura(render_widget_host, is_guest_view_hack);
+ TouchSelectionControllerAuraClientImpl* selection_controller_client =
+ new TouchSelectionControllerAuraClientImpl(view);
+ view->InitSelectionController(selection_controller_client);
+
view->InitAsChild(NULL);
GetNativeView()->AddChild(view->GetNativeView());
@@ -1151,7 +1154,6 @@ RenderWidgetHostViewBase* WebContentsViewAura::CreateViewForWidget(
InstallOverscrollControllerDelegate(view);
}
- AttachTouchEditableToRenderView();
return view;
}
@@ -1170,7 +1172,6 @@ void WebContentsViewAura::RenderViewCreated(RenderViewHost* host) {
void WebContentsViewAura::RenderViewSwappedIn(RenderViewHost* host) {
if (navigation_overlay_.get() && navigation_overlay_->has_window())
navigation_overlay_->StartObserving();
- AttachTouchEditableToRenderView();
}
void WebContentsViewAura::SetOverscrollControllerEnabled(bool enabled) {
@@ -1193,9 +1194,10 @@ void WebContentsViewAura::SetOverscrollControllerEnabled(bool enabled) {
void WebContentsViewAura::ShowContextMenu(RenderFrameHost* render_frame_host,
const ContextMenuParams& params) {
- if (touch_editable_) {
- touch_editable_->EndTouchEditing(false);
- }
+ ui::TouchSelectionControllerAura* selection_controller =
+ GetSelectionController();
+ if (selection_controller)
+ selection_controller->HideAndDisallowShowingAutomatically();
if (delegate_) {
delegate_->ShowContextMenu(render_frame_host, params);
// WARNING: we may have been deleted during the call to ShowContextMenu().
@@ -1214,9 +1216,10 @@ void WebContentsViewAura::StartDragging(
return;
}
- if (touch_editable_)
- touch_editable_->EndTouchEditing(false);
-
+ ui::TouchSelectionControllerAura* selection_controller =
+ GetSelectionController();
+ if (selection_controller)
+ selection_controller->HideAndDisallowShowingAutomatically();
ui::OSExchangeData::Provider* provider = ui::OSExchangeData::CreateProvider();
PrepareDragData(drop_data, provider, web_contents_);
@@ -1348,9 +1351,12 @@ void WebContentsViewAura::OnOverscrollModeChange(OverscrollMode old_mode,
if (old_mode == OVERSCROLL_NORTH || old_mode == OVERSCROLL_SOUTH)
OverscrollUpdateForWebContentsDelegate(0);
- if (new_mode != OVERSCROLL_NONE && touch_editable_)
- touch_editable_->OverscrollStarted();
-
+ if (new_mode != OVERSCROLL_NONE) {
+ ui::TouchSelectionControllerAura* selection_controller =
+ GetSelectionController();
+ if (selection_controller)
+ selection_controller->OnOverscrollStarted();
+ }
if (new_mode == OVERSCROLL_NONE ||
!GetContentNativeView() ||
((new_mode == OVERSCROLL_EAST || new_mode == OVERSCROLL_WEST) &&
@@ -1391,8 +1397,10 @@ void WebContentsViewAura::OnImplicitAnimationsCompleted() {
web_contents_->GetController().GoBack();
PrepareOverscrollNavigationOverlay();
} else {
- if (touch_editable_)
- touch_editable_->OverscrollCompleted();
+ ui::TouchSelectionControllerAura* selection_controller =
+ GetSelectionController();
+ if (selection_controller)
+ selection_controller->OnOverscrollCompleted();
}
aura::Window* content = GetContentNativeView();

Powered by Google App Engine
This is Rietveld 408576698