Chromium Code Reviews| Index: content/renderer/render_widget.cc |
| diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc |
| index c512d41fce1f9ef2586cbe2d416d3b84e793210e..ea8f9197571f47b64fc02d3e71668265b3f59d45 100644 |
| --- a/content/renderer/render_widget.cc |
| +++ b/content/renderer/render_widget.cc |
| @@ -2013,10 +2013,20 @@ void RenderWidget::UpdateSelectionBounds() { |
| if (handling_ime_event_) |
| return; |
| +#if defined(USE_AURA) |
| + // TODO(mohsen): For now, always send explicit selection IPC notifications for |
| + // Aura beucause composited selection updates are not working for webview tags |
| + // which regresses IME inside webview. Remove this when composited selection |
| + // updates are fixed for webviews. |
|
sadrul
2015/06/30 18:33:12
Can you file a crbug and reference that from here?
mohsen
2015/07/03 18:07:23
That would be a bug against a code that is not yet
sadrul
2015/07/15 17:00:15
That's OK. You can file a bug for TODO and referen
mohsen
2015/07/16 22:06:19
Done.
|
| + bool send_ipc = true; |
| +#else |
| // With composited selection updates, the selection bounds will be reported |
| // directly by the compositor, in which case explicit IPC selection |
| // notifications should be suppressed. |
| - if (!blink::WebRuntimeFeatures::isCompositedSelectionUpdateEnabled()) { |
| + bool send_ipc = |
| + !blink::WebRuntimeFeatures::isCompositedSelectionUpdateEnabled(); |
| +#endif |
| + if (send_ipc) { |
| ViewHostMsg_SelectionBounds_Params params; |
| GetSelectionBounds(¶ms.anchor_rect, ¶ms.focus_rect); |
| if (selection_anchor_rect_ != params.anchor_rect || |