content/browser/renderer_host/ui_touch_selection_helper.h - Issue 698253004: Reland: Implement Aura side of unified touch text selection for contents

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/renderer_host/ui_touch_selection_helper.h

Issue 698253004: Reland: Implement Aura side of unified touch text selection for contents (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup - ready for review Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | content/browser/renderer_host/ui_touch_selection_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_BROWSER_RENDERER_HOST_UI_TOUCH_SELECTION_HELPER_H_

	6 #define CONTENT_BROWSER_RENDERER_HOST_UI_TOUCH_SELECTION_HELPER_H_

	7

	8 namespace cc {

	9 struct ViewportSelectionBound;

	10 }

	11

	12 namespace ui {
	jdduke (slow) 2015/02/24 16:53:47 Let's go ahead and include the necessary ui::Selec Let's go ahead and include the necessary ui::SelectionBound header, as we're returning by value. Also, can we move this file to renderer_host/input? mohsen 2015/02/25 23:52:19 Sure. Done. Show quoted text On 2015/02/24 16:53:47, jdduke wrote: > Let's go ahead and include the necessary ui::SelectionBound header, as we're > returning by value. > > Also, can we move this file to renderer_host/input? Sure. Done.
	13 class SelectionBound;

	14 }

	15

	16 namespace content {

	17

	18 ui::SelectionBound ConvertSelectionBound(

	19 const cc::ViewportSelectionBound& bound);

	20

	21 } // namespace content

	22

	23 #endif // CONTENT_BROWSER_RENDERER_HOST_UI_TOUCH_SELECTION_HELPER_H_

OLD	NEW