Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: Source/core/dom/Document.h

Issue 69823002: Move ownership of the TextResourceDecoder to DecodedDataDocumentParser (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Moved DocumentEncodingData to its own header Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Document.h
diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h
index 00a32b950168fcb1b1c303f6991465c131af3ea2..dac19a7e4546266828b16466a896b70556465ec9 100644
--- a/Source/core/dom/Document.h
+++ b/Source/core/dom/Document.h
@@ -31,6 +31,7 @@
#include "bindings/v8/ScriptValue.h"
#include "core/dom/ContainerNode.h"
#include "core/dom/DOMTimeStamp.h"
+#include "core/dom/DocumentEncodingData.h"
#include "core/dom/DocumentInit.h"
#include "core/dom/DocumentLifecycle.h"
#include "core/dom/DocumentSupplementable.h"
@@ -152,7 +153,6 @@ class StyleSheetContents;
class StyleSheetList;
class Text;
class TextAutosizer;
-class TextResourceDecoder;
class Touch;
class TouchList;
class TransformSource;
@@ -841,11 +841,12 @@ public:
void finishedParsing();
- void setDecoder(PassRefPtr<TextResourceDecoder>);
- TextResourceDecoder* decoder() const { return m_decoder.get(); }
+ void setEncodingData(const DocumentEncodingData& newData);
+ const DocumentEncodingData& encodingData() const { return m_encodingData; }
abarth-chromium 2013/11/14 07:04:33 I didn't see any callers for this function. Can w
oystein (OOO til 10th of July) 2013/11/14 19:02:29 Done.
+ const WTF::TextEncoding& encoding() const { return m_encodingData.encoding; }
- void setEncoding(const WTF::TextEncoding&);
- const WTF::TextEncoding& encoding() const { return m_encoding; }
+ bool encodingWasDetectedHeuristically() const { return m_encodingData.wasDetectedHeuristically; }
+ bool sawDecodingError() const { return m_encodingData.sawDecodingError; }
void setAnnotatedRegionsDirty(bool f) { m_annotatedRegionsDirty = f; }
bool annotatedRegionsDirty() const { return m_annotatedRegionsDirty; }
@@ -1231,8 +1232,7 @@ private:
String m_contentLanguage;
- RefPtr<TextResourceDecoder> m_decoder;
- WTF::TextEncoding m_encoding;
+ DocumentEncodingData m_encodingData;
InheritedBool m_designMode;

Powered by Google App Engine
This is Rietveld 408576698