Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: Source/core/dom/DocumentParser.cpp

Issue 69823002: Move ownership of the TextResourceDecoder to DecodedDataDocumentParser (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review fixes Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/DocumentParser.h ('k') | Source/core/fetch/TextResourceDecoder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google, Inc. All Rights Reserved. 2 * Copyright (C) 2010 Google, Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "config.h" 26 #include "config.h"
27 #include "core/dom/DocumentParser.h" 27 #include "core/dom/DocumentParser.h"
28 #include "core/fetch/TextResourceDecoder.h"
28 29
29 #include "wtf/Assertions.h" 30 #include "wtf/Assertions.h"
30 31
31 namespace WebCore { 32 namespace WebCore {
32 33
33 DocumentParser::DocumentParser(Document* document) 34 DocumentParser::DocumentParser(Document* document)
34 : m_state(ParsingState) 35 : m_state(ParsingState)
35 , m_documentWasLoadedAsPartOfNavigation(false) 36 , m_documentWasLoadedAsPartOfNavigation(false)
36 , m_document(document) 37 , m_document(document)
37 { 38 {
38 ASSERT(document); 39 ASSERT(document);
39 } 40 }
40 41
41 DocumentParser::~DocumentParser() 42 DocumentParser::~DocumentParser()
42 { 43 {
43 // Document is expected to call detach() before releasing its ref. 44 // Document is expected to call detach() before releasing its ref.
44 // This ASSERT is slightly awkward for parsers with a fragment case 45 // This ASSERT is slightly awkward for parsers with a fragment case
45 // as there is no Document to release the ref. 46 // as there is no Document to release the ref.
46 ASSERT(!m_document); 47 ASSERT(!m_document);
47 } 48 }
48 49
50 void DocumentParser::setDecoder(PassRefPtr<TextResourceDecoder>)
51 {
52 ASSERT_NOT_REACHED();
53 }
54
55 PassRefPtr<TextResourceDecoder> DocumentParser::decoder()
56 {
57 return 0;
58 }
59
49 void DocumentParser::startParsing() 60 void DocumentParser::startParsing()
50 { 61 {
51 m_state = ParsingState; 62 m_state = ParsingState;
52 } 63 }
53 64
54 void DocumentParser::prepareToStopParsing() 65 void DocumentParser::prepareToStopParsing()
55 { 66 {
56 ASSERT(m_state == ParsingState); 67 ASSERT(m_state == ParsingState);
57 m_state = StoppingState; 68 m_state = StoppingState;
58 } 69 }
(...skipping 12 matching lines...) Expand all
71 void DocumentParser::suspendScheduledTasks() 82 void DocumentParser::suspendScheduledTasks()
72 { 83 {
73 } 84 }
74 85
75 void DocumentParser::resumeScheduledTasks() 86 void DocumentParser::resumeScheduledTasks()
76 { 87 {
77 } 88 }
78 89
79 }; 90 };
80 91
OLDNEW
« no previous file with comments | « Source/core/dom/DocumentParser.h ('k') | Source/core/fetch/TextResourceDecoder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698