Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: Source/core/dom/DecodedDataDocumentParser.h

Issue 69823002: Move ownership of the TextResourceDecoder to DecodedDataDocumentParser (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review fixes Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/dom/DecodedDataDocumentParser.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google, Inc. All Rights Reserved. 2 * Copyright (C) 2010 Google, Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef DecodedDataDocumentParser_h 26 #ifndef DecodedDataDocumentParser_h
27 #define DecodedDataDocumentParser_h 27 #define DecodedDataDocumentParser_h
28 28
29 #include "core/dom/DocumentParser.h" 29 #include "core/dom/DocumentParser.h"
30 #include "wtf/RefPtr.h"
30 31
31 namespace WebCore { 32 namespace WebCore {
33 class TextResourceDecoder;
32 34
33 class DecodedDataDocumentParser : public DocumentParser { 35 class DecodedDataDocumentParser : public DocumentParser {
34 public: 36 public:
35 // Only used by the XMLDocumentParser to communicate back to 37 // Only used by the XMLDocumentParser to communicate back to
36 // XMLHttpRequest if the responseXML was well formed. 38 // XMLHttpRequest if the responseXML was well formed.
37 virtual bool wellFormed() const { return true; } 39 virtual bool wellFormed() const { return true; }
38 40
41 // The below functions are used by DocumentWriter (the loader).
42 virtual size_t appendBytes(const char* bytes, size_t length) OVERRIDE;
43 virtual size_t flush() OVERRIDE;
44 virtual bool needsDecoder() const OVERRIDE { return !m_decoder; }
45 virtual void setDecoder(PassRefPtr<TextResourceDecoder>) OVERRIDE;
46 virtual PassRefPtr<TextResourceDecoder> decoder() OVERRIDE;
47
39 protected: 48 protected:
40 explicit DecodedDataDocumentParser(Document*); 49 explicit DecodedDataDocumentParser(Document*);
50 virtual ~DecodedDataDocumentParser();
41 51
42 private: 52 private:
43 // append is used by DocumentWriter::replaceDocument. 53 // append is used by DocumentWriter::replaceDocument.
44 virtual void append(PassRefPtr<StringImpl>) = 0; 54 virtual void append(PassRefPtr<StringImpl>) = 0;
45 55
46 // appendBytes and flush are used by DocumentWriter (the loader). 56 void updateDocumentEncoding();
47 virtual size_t appendBytes(const char* bytes, size_t length) OVERRIDE; 57
48 virtual size_t flush() OVERRIDE; 58 RefPtr<TextResourceDecoder> m_decoder;
49 virtual bool needsDecoder() const OVERRIDE { return true; }
50 }; 59 };
51 60
52 } 61 }
53 62
54 #endif // DecodedDataDocumentParser_h 63 #endif // DecodedDataDocumentParser_h
OLDNEW
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/dom/DecodedDataDocumentParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698