Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 698213002: Remove lots of Text APIs. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove lots of Text APIs. I also removed Node#normalize() which is Text related and doesn't seem like something we need. Frameworks can implement it if needed. Remove most of the media stack. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f3c52734fc2744b1b56edf8dcd27a5f9b3cba239

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -181 lines) Patch
M sky/engine/core/dom/Node.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Node.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
M sky/engine/core/dom/Text.h View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/core/dom/Text.cpp View 2 chunks +0 lines, -139 lines 0 comments Download
M sky/engine/core/dom/Text.idl View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/html/ime/InputMethodContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/ime/InputMethodContext.cpp View 1 chunk +0 lines, -9 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
ojan
lgtm https://codereview.chromium.org/698213002/diff/20001/sky/engine/core/html/ime/InputMethodContext.cpp File sky/engine/core/html/ime/InputMethodContext.cpp (left): https://codereview.chromium.org/698213002/diff/20001/sky/engine/core/html/ime/InputMethodContext.cpp#oldcode98 sky/engine/core/html/ime/InputMethodContext.cpp:98: String InputMethodContext::compositionText() const I'm a little surprised this ...
6 years, 1 month ago (2014-11-04 05:54:53 UTC) #2
esprehn
On 2014/11/04 at 05:54:53, ojan wrote: > lgtm > > https://codereview.chromium.org/698213002/diff/20001/sky/engine/core/html/ime/InputMethodContext.cpp > File sky/engine/core/html/ime/InputMethodContext.cpp (left): ...
6 years, 1 month ago (2014-11-04 06:28:56 UTC) #3
esprehn
6 years, 1 month ago (2014-11-04 06:34:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f3c52734fc2744b1b56edf8dcd27a5f9b3cba239.

Powered by Google App Engine
This is Rietveld 408576698