Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 698203003: Convert fast/multicol/unsplittable-inline-block to reftest. (Closed)

Created:
6 years, 1 month ago by andersr
Modified:
6 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Convert fast/multicol/unsplittable-inline-block to reftest. Removed explicit 'width' and shortened text lines to make the test "compatible" with vertical-lr/rl. R=mstensho@opera.com BUG=386567 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184916

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -587 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/multicol/unsplittable-inline-block.html View 1 chunk +31 lines, -18 lines 1 comment Download
A LayoutTests/fast/multicol/unsplittable-inline-block-expected.html View 1 chunk +38 lines, -0 lines 0 comments Download
M LayoutTests/fast/multicol/vertical-lr/unsplittable-inline-block.html View 1 chunk +34 lines, -19 lines 0 comments Download
A LayoutTests/fast/multicol/vertical-lr/unsplittable-inline-block-expected.html View 1 chunk +41 lines, -0 lines 0 comments Download
M LayoutTests/fast/multicol/vertical-rl/unsplittable-inline-block.html View 1 chunk +34 lines, -19 lines 0 comments Download
A LayoutTests/fast/multicol/vertical-rl/unsplittable-inline-block-expected.html View 1 chunk +41 lines, -0 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/unsplittable-inline-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/unsplittable-inline-block-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/platform/linux/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/platform/mac-lion/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-snowleopard/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/unsplittable-inline-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/unsplittable-inline-block-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/unsplittable-inline-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/unsplittable-inline-block-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/unsplittable-inline-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/unsplittable-inline-block-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-lr/unsplittable-inline-block-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/multicol/vertical-rl/unsplittable-inline-block-expected.txt View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
andersr
6 years, 1 month ago (2014-11-04 12:34:20 UTC) #1
mstensho (USE GERRIT)
lgtm https://codereview.chromium.org/698203003/diff/1/LayoutTests/fast/multicol/unsplittable-inline-block.html File LayoutTests/fast/multicol/unsplittable-inline-block.html (right): https://codereview.chromium.org/698203003/diff/1/LayoutTests/fast/multicol/unsplittable-inline-block.html#newcode11 LayoutTests/fast/multicol/unsplittable-inline-block.html:11: } No issue, but note that dashes in ...
6 years, 1 month ago (2014-11-04 21:36:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698203003/1
6 years, 1 month ago (2014-11-06 14:12:37 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 15:22:53 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184916

Powered by Google App Engine
This is Rietveld 408576698