Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 6982022: Merge the dynamic annotations from ThreadSanitizer r3424. (Closed)

Created:
9 years, 7 months ago by Timur Iskhodzhanov
Modified:
9 years, 6 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Merge the dynamic annotations from ThreadSanitizer r3424. This introduces two major changes: - each annotation has a non-trivial implementation which prevents identical code folding - ANNOTATE_HAPPENS_BEFORE and ANNOTATE_HAPPENS_AFTER are separated from ANNOTATE_CONDVAR_{SIGNAL,WAIT}. The corresponding annotation functions are supported by ThreadSanitizer as of r3075 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84975

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -45 lines) Patch
M base/third_party/dynamic_annotations/dynamic_annotations.h View 4 chunks +11 lines, -6 lines 0 comments Download
M base/third_party/dynamic_annotations/dynamic_annotations.c View 3 chunks +126 lines, -39 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Timur Iskhodzhanov
9 years, 7 months ago (2011-05-11 11:21:24 UTC) #1
Alexander Potapenko
On 2011/05/11 11:21:24, Timur Iskhodzhanov wrote: Have you split the lines that are longer than ...
9 years, 7 months ago (2011-05-11 12:05:43 UTC) #2
Timur Iskhodzhanov
I fixed them by copying the new upstream version with shorter lines. On 2011/05/11 12:05:43, ...
9 years, 7 months ago (2011-05-11 12:07:08 UTC) #3
Timur Iskhodzhanov
Hi William, Can you please review this CL? The diff is basically just a copy ...
9 years, 7 months ago (2011-05-11 12:25:55 UTC) #4
Timur Iskhodzhanov
FYI I believe the mac and linux_tsan failures are unrelated. The linux_tsan failure is similar ...
9 years, 7 months ago (2011-05-11 13:58:28 UTC) #5
willchan no longer on Chromium
LGTM
9 years, 7 months ago (2011-05-11 14:18:46 UTC) #6
Timur Iskhodzhanov
9 years, 7 months ago (2011-05-11 14:31:02 UTC) #7
Thanks!

Powered by Google App Engine
This is Rietveld 408576698