Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 698153005: Fix socket send. (Closed)

Created:
6 years, 1 month ago by rkc
Modified:
6 years, 1 month ago
Reviewers:
xiyuan
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix socket send. Instead of calling CopresenceSocket::Send with the size of the packet we created, we were calling it with the size of the original data. This CL fixes that bug and adds more logging when we're sending data. R=xiyuan@chromium.org BUG=None. Committed: https://crrev.com/89763279e7c46196bad17e9c5f31abb0ccffa2b1 Cr-Commit-Position: refs/heads/master@{#302656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M extensions/browser/api/copresence_socket/copresence_socket_api.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rkc
6 years, 1 month ago (2014-11-04 19:12:01 UTC) #1
xiyuan
lgtm
6 years, 1 month ago (2014-11-04 19:13:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698153005/1
6 years, 1 month ago (2014-11-04 19:15:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 20:23:37 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 20:25:40 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/89763279e7c46196bad17e9c5f31abb0ccffa2b1
Cr-Commit-Position: refs/heads/master@{#302656}

Powered by Google App Engine
This is Rietveld 408576698