Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 69813010: Do not issue preflight for crossorigin media resource loads. (Closed)

Created:
7 years, 1 month ago by sof
Modified:
7 years, 1 month ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Do not issue preflight for crossorigin media resource loads. Turn off preflighting when issuing requests that are CORS enabled fetches. The requests do not have any author headers, hence should go ahead without a preflighting step. CORS-enabled servers sometimes depend on this. R=jochen BUG=173727 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/renderer/media/android/media_info_loader.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/buffered_resource_loader.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
sof
At your leisure, please have a look. Depends on the public API change in https://codereview.chromium.org/68173029/ ...
7 years, 1 month ago (2013-11-18 09:50:33 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-11-18 12:00:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/69813010/1
7 years, 1 month ago (2013-11-18 18:21:47 UTC) #3
scherkus (not reviewing)
do we have any tests for this?
7 years, 1 month ago (2013-11-18 18:41:41 UTC) #4
sof
On 2013/11/18 18:41:41, scherkus wrote: > do we have any tests for this? Yes, https://codereview.chromium.org/75153002/ ...
7 years, 1 month ago (2013-11-18 18:43:15 UTC) #5
sof
On 2013/11/18 18:43:15, sof wrote: > On 2013/11/18 18:41:41, scherkus wrote: > > do we ...
7 years, 1 month ago (2013-11-18 18:47:04 UTC) #6
scherkus (not reviewing)
On 2013/11/18 18:47:04, sof wrote: > On 2013/11/18 18:43:15, sof wrote: > > On 2013/11/18 ...
7 years, 1 month ago (2013-11-18 18:48:38 UTC) #7
Ken Russell (switch to Gerrit)
lgtm
7 years, 1 month ago (2013-11-18 19:01:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/69813010/1
7 years, 1 month ago (2013-11-19 05:17:33 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=191889
7 years, 1 month ago (2013-11-19 05:51:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/69813010/1
7 years, 1 month ago (2013-11-19 06:40:58 UTC) #11
commit-bot: I haz the power
7 years, 1 month ago (2013-11-19 10:13:40 UTC) #12
Message was sent while issue was closed.
Change committed as 235958

Powered by Google App Engine
This is Rietveld 408576698