Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: sky/engine/core/dom/Node.h

Issue 698123002: Remove more API from Node and ContainerNode. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/MutationObserverRegistration.cpp ('k') | sky/engine/core/dom/Node.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/Node.h
diff --git a/sky/engine/core/dom/Node.h b/sky/engine/core/dom/Node.h
index 77e115e212fb1ed3ab8e6264bf9ca7a8602eee48..9efa372d6f8bb9ee555a349f882920431187d5a1 100644
--- a/sky/engine/core/dom/Node.h
+++ b/sky/engine/core/dom/Node.h
@@ -107,12 +107,9 @@ protected:
// TreeShared should be the last to pack TreeShared::m_refCount and
// Node::m_nodeFlags on 64bit platforms.
-#define NODE_BASE_CLASSES public EventTarget, public TreeShared<Node>
-
-class Node : NODE_BASE_CLASSES {
+class Node : public EventTarget, public TreeShared<Node> {
DEFINE_EVENT_TARGET_REFCOUNTING_WILL_BE_REMOVED(TreeShared<Node>);
DEFINE_WRAPPERTYPEINFO();
- WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(Node);
friend class Document;
friend class TreeScope;
friend class TreeScopeAdopter;
@@ -149,8 +146,6 @@ public:
bool hasTagName(const HTMLQualifiedName&) const;
virtual String nodeName() const = 0;
- virtual String nodeValue() const;
- virtual void setNodeValue(const String&);
virtual NodeType nodeType() const = 0;
ContainerNode* parentNode() const;
Element* parentElement() const;
@@ -571,8 +566,6 @@ public:
void setAlreadySpellChecked(bool flag) { setFlag(flag, AlreadySpellCheckedFlag); }
bool isAlreadySpellChecked() { return getFlag(AlreadySpellCheckedFlag); }
- virtual void trace(Visitor*) override;
-
unsigned lengthOfContents() const;
virtual v8::Handle<v8::Object> wrap(v8::Handle<v8::Object> creationContext, v8::Isolate*) override;
« no previous file with comments | « sky/engine/core/dom/MutationObserverRegistration.cpp ('k') | sky/engine/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698