Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: sky/engine/core/dom/ContainerNode.cpp

Issue 698123002: Remove more API from Node and ContainerNode. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/ContainerNode.h ('k') | sky/engine/core/dom/Document.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/ContainerNode.cpp
diff --git a/sky/engine/core/dom/ContainerNode.cpp b/sky/engine/core/dom/ContainerNode.cpp
index 0335730c8a8ba229d5b388b40254f2f9a1b155d2..b5418691369e6f4cac0b88ddc970819ab1b1b5e7 100644
--- a/sky/engine/core/dom/ContainerNode.cpp
+++ b/sky/engine/core/dom/ContainerNode.cpp
@@ -60,22 +60,11 @@ static void collectChildrenAndRemoveFromOldParent(Node& node, NodeVector& nodes,
oldParent->removeChild(&node, exceptionState);
}
-#if !ENABLE(OILPAN)
void ContainerNode::removeDetachedChildren()
{
ASSERT(needsAttach());
removeDetachedChildrenInContainer(*this);
}
-#endif
-
-void ContainerNode::parserTakeAllChildrenFrom(ContainerNode& oldParent)
-{
- while (RefPtr<Node> child = oldParent.firstChild()) {
- oldParent.parserRemoveChild(*child);
- treeScope().adoptIfNeeded(*child);
- parserAppendChild(child.get());
- }
-}
ContainerNode::~ContainerNode()
{
@@ -470,13 +459,6 @@ void ContainerNode::addChildNodesToDeletionQueue(Node*& head, Node*& tail, Conta
}
#endif
-void ContainerNode::trace(Visitor* visitor)
-{
- visitor->trace(m_firstChild);
- visitor->trace(m_lastChild);
- Node::trace(visitor);
-}
-
PassRefPtr<Node> ContainerNode::removeChild(PassRefPtr<Node> oldChild, ExceptionState& exceptionState)
{
#if !ENABLE(OILPAN)
@@ -509,7 +491,7 @@ PassRefPtr<Node> ContainerNode::removeChild(PassRefPtr<Node> oldChild, Exception
Node* next = child->nextSibling();
removeBetween(prev, next, *child);
notifyNodeRemoved(*child);
- childrenChanged(ChildrenChange::forRemoval(*child, prev, next, ChildrenChangeSourceAPI));
+ childrenChanged(ChildrenChange::forRemoval(*child, ChildrenChangeSourceAPI));
return child;
}
@@ -553,7 +535,7 @@ void ContainerNode::parserRemoveChild(Node& oldChild)
removeBetween(prev, next, oldChild);
notifyNodeRemoved(oldChild);
- childrenChanged(ChildrenChange::forRemoval(oldChild, prev, next, ChildrenChangeSourceParser));
+ childrenChanged(ChildrenChange::forRemoval(oldChild, ChildrenChangeSourceParser));
}
// this differs from other remove functions because it forcibly removes all the children,
@@ -599,7 +581,7 @@ void ContainerNode::removeChildren()
notifyNodeRemoved(*child);
}
- ChildrenChange change = {AllChildrenRemoved, nullptr, nullptr, ChildrenChangeSourceAPI};
+ ChildrenChange change = {AllChildrenRemoved, ChildrenChangeSourceAPI};
childrenChanged(change);
}
}
« no previous file with comments | « sky/engine/core/dom/ContainerNode.h ('k') | sky/engine/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698