Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 698113006: DevTools: [SSP] update ranges for all section in sidebar pane (Closed)

Created:
6 years, 1 month ago by lushnikov
Modified:
6 years, 1 month ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: [SSP] update ranges for all section in sidebar pane There is a bug due to which source ranges in inherited styles sections and pseudo elements style sections are not updated on the front-end as the editing happens. This patch fixes it. BUG=430129 R=vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184861

Patch Set 1 #

Patch Set 2 : rebaseline test #

Total comments: 4

Patch Set 3 : address comments #

Patch Set 4 : fixup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -61 lines) Patch
M LayoutTests/http/tests/inspector/elements-test.js View 1 2 1 chunk +11 lines, -5 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-update-links.html View 1 2 3 3 chunks +100 lines, -53 lines 0 comments Download
M LayoutTests/inspector/elements/styles/styles-update-links-expected.txt View 1 4 chunks +47 lines, -0 lines 0 comments Download
M Source/devtools/front_end/elements/StylesSidebarPane.js View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
lushnikov
Please, take a look
6 years, 1 month ago (2014-11-04 17:46:55 UTC) #1
vsevik
lgtm https://codereview.chromium.org/698113006/diff/20001/LayoutTests/http/tests/inspector/elements-test.js File LayoutTests/http/tests/inspector/elements-test.js (right): https://codereview.chromium.org/698113006/diff/20001/LayoutTests/http/tests/inspector/elements-test.js#newcode371 LayoutTests/http/tests/inspector/elements-test.js:371: for (var pseudoId in WebInspector.panels.elements.sidebarPanes.styles.sections) { Extract WebInspector.panels.elements.sidebarPanes.styles? ...
6 years, 1 month ago (2014-11-05 06:49:11 UTC) #2
lushnikov
https://codereview.chromium.org/698113006/diff/20001/LayoutTests/http/tests/inspector/elements-test.js File LayoutTests/http/tests/inspector/elements-test.js (right): https://codereview.chromium.org/698113006/diff/20001/LayoutTests/http/tests/inspector/elements-test.js#newcode371 LayoutTests/http/tests/inspector/elements-test.js:371: for (var pseudoId in WebInspector.panels.elements.sidebarPanes.styles.sections) { On 2014/11/05 06:49:11, ...
6 years, 1 month ago (2014-11-05 08:51:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698113006/60001
6 years, 1 month ago (2014-11-05 08:51:31 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 09:54:54 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as 184861

Powered by Google App Engine
This is Rietveld 408576698