LayoutTests/editing/execCommand/crash-object-cloning.html - Issue 698113005: The ASSERT in appendNode() should not fire when OBJECTS are cloned.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/execCommand/crash-object-cloning.html

Issue 698113005: The ASSERT in appendNode() should not fire when OBJECTS are cloned. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Full patch Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script>

	3 if (window.testRunner)

	4 {
	yosin_UTC9 2014/11/20 01:26:41 nit: Move \|{\| to end of \|if\| line. Basically, plea nit: Move \|{\| to end of \|if\| line. Basically, please format as C++.
	5 window.testRunner.dumpAsText();

	6 testRunner.waitUntilDone();
	yosin_UTC9 2014/11/20 01:26:41 Please add \|window.jsTestAsync = true;\|, when we c Please add \|window.jsTestAsync = true;\|, when we call \|testRunner.waitUntilDone()\|.
	7 }

	8 window.onload = function() {
	yosin_UTC9 2014/11/20 01:26:41 Do we really need to wait "load" event for this te Do we really need to wait "load" event for this test? How about moving <script> block after </body>?
	9 document.execCommand("SelectAll",false);
	yosin_UTC9 2014/11/20 01:26:41 nit: You don't need to have \|,false\|. nit: You don't need to have \|,false\|.
	10 document.execCommand("Indent", false);
	yosin_UTC9 2014/11/20 01:26:41 nit: You don't need to have \|,false\|. nit: You don't need to have \|,false\|.
	11 setTimeout(function() {

	12 document.getElementById("body").innerHTML = "This test passes if it does n't crash";

	13 testRunner.notifyDone();

	14 }, 0);

	15 };

	16 </script>

	17 <body id="body" contenteditable>

	18 <object>

	19 This test passes if it doesn't crash

	20 </body>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/execCommand/crash-object-cloning-expected.txt » ('j') | Source/core/editing/CompositeEditCommand.cpp » ('J')