Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 698103003: Chromoting Linux host: Replace subprocess.Popen() with subprocess.call() (Closed)

Created:
6 years, 1 month ago by Lambros
Modified:
6 years, 1 month ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@increase-xvfb-timeout
Project:
chromium
Visibility:
Public.

Description

Chromoting Linux host: Replace subprocess.Popen() with subprocess.call() subprocess.call() is documented as accepting the same arguments as subprocess.Popen(). This lets us simplify some usages. NOTRY=true Committed: https://crrev.com/1492c3d296476fe127c56fc889571f33cc59da43 Cr-Commit-Position: refs/heads/master@{#302630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M remoting/host/linux/linux_me2me_host.py View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Lambros
6 years, 1 month ago (2014-11-04 01:54:32 UTC) #2
Jamie
lgtm
6 years, 1 month ago (2014-11-04 02:49:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698103003/1
6 years, 1 month ago (2014-11-04 18:31:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 18:32:31 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 18:33:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1492c3d296476fe127c56fc889571f33cc59da43
Cr-Commit-Position: refs/heads/master@{#302630}

Powered by Google App Engine
This is Rietveld 408576698