Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: src/harmony-classes.js

Issue 698073005: Classes: Fix issue with default constructor crash (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file relies on the fact that the following declarations have been made 5 // This file relies on the fact that the following declarations have been made
6 // in runtime.js: 6 // in runtime.js:
7 // var $Function = global.Function; 7 // var $Function = global.Function;
8 // var $Array = global.Array; 8 // var $Array = global.Array;
9 9
10 10
11 function DefaultConstructor() {
12 // TODO(arv): Handle arguments.
13 super();
14 }
15
16
17 function DefaultConstructorNoSuper() {}
18
19
11 (function() { 20 (function() {
12 function FunctionToMethod(homeObject) { 21 function FunctionToMethod(homeObject) {
13 if (!IS_SPEC_FUNCTION(this)) { 22 if (!IS_SPEC_FUNCTION(this)) {
14 throw MakeTypeError('toMethod_non_function', 23 throw MakeTypeError('toMethod_non_function',
15 [%ToString(this), typeof this]); 24 [%ToString(this), typeof this]);
16 25
17 } 26 }
18 27
19 if (!IS_SPEC_OBJECT(homeObject)) { 28 if (!IS_SPEC_OBJECT(homeObject)) {
20 throw MakeTypeError('toMethod_non_object', 29 throw MakeTypeError('toMethod_non_object',
21 [%ToString(homeObject)]); 30 [%ToString(homeObject)]);
22 } 31 }
23 32
24 return %ToMethod(this, homeObject); 33 return %ToMethod(this, homeObject);
25 } 34 }
26 35
27 %CheckIsBootstrapping(); 36 %CheckIsBootstrapping();
28 37
29 InstallFunctions($Function.prototype, DONT_ENUM, $Array( 38 InstallFunctions($Function.prototype, DONT_ENUM, $Array(
30 "toMethod", FunctionToMethod 39 "toMethod", FunctionToMethod
31 )); 40 ));
32 }()); 41 }());
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698