Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 698053003: DevTools: do not show "there are unsaved changes" dialog for network resources (Closed)

Created:
6 years, 1 month ago by lushnikov
Modified:
6 years, 1 month ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: do not show "there are unsaved changes" dialog for network resources DevTools shows "there are unsaved changes" dialog if there's at least one dirty uiSourceCode. However, saving a network-originated javascript file will not prevent you from loosing changes as the devtools will close. This patch changes the behavior so that the alerting message pops up only if there are file system uiSourceCodes with unsaved changes. R=vsevik BUG=426783 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184856

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M Source/devtools/front_end/workspace/Workspace.js View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
lushnikov
ptal
6 years, 1 month ago (2014-11-04 06:12:00 UTC) #1
vsevik
lgtm
6 years, 1 month ago (2014-11-05 07:35:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698053003/1
6 years, 1 month ago (2014-11-05 07:36:25 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 08:40:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184856

Powered by Google App Engine
This is Rietveld 408576698