Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 698033002: Fix GN ui_unittests dependency for Chrome OS. (Closed)

Created:
6 years, 1 month ago by Ben Chan
Modified:
6 years, 1 month ago
Reviewers:
stevenjb, sadrul, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix GN ui_unittests dependency for Chrome OS. This CL replaces the mistyped //chromeos/resources and //chromeos/strings dependency (introduced by r302142) with //ui/chromeos/resources and //ui/chromeos/strings. BUG=None TEST=Run `gn gen --args='os="chromeos" ...` Committed: https://crrev.com/9f3da8d4d5e068fdb32a8ed3d4c8f30a03de8ee0 Cr-Commit-Position: refs/heads/master@{#302450}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ui/base/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Ben Chan
6 years, 1 month ago (2014-11-03 17:30:26 UTC) #2
stevenjb
lgtm, thanks!
6 years, 1 month ago (2014-11-03 17:58:38 UTC) #3
sadrul
lgtm
6 years, 1 month ago (2014-11-03 17:59:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698033002/1
6 years, 1 month ago (2014-11-03 18:01:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-03 18:42:20 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 18:42:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f3da8d4d5e068fdb32a8ed3d4c8f30a03de8ee0
Cr-Commit-Position: refs/heads/master@{#302450}

Powered by Google App Engine
This is Rietveld 408576698