Source/core/dom/DOMDataView.h - Issue 698023005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/DOMDataView.h

Issue 698023005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/DOMDataView.h

diff --git a/Source/core/dom/DOMDataView.h b/Source/core/dom/DOMDataView.h

index 85576b00abbad564caee6bdd697d0f7dc34bf575..facd7b3c9570594a8edb90c118e02f379bb311b9 100644

--- a/Source/core/dom/DOMDataView.h

+++ b/Source/core/dom/DOMDataView.h

@@ -19,7 +19,7 @@ public:

DataView* view() { return static_cast<DataView*>(DOMArrayBufferView::view()); }

virtual v8::Handle<v8::Object> wrap(v8::Handle<v8::Object> creationContext, v8::Isolate*) override;

- virtual v8::Handle<v8::Object> associateWithWrapper(const WrapperTypeInfo*, v8::Handle<v8::Object> wrapper, v8::Isolate*) override;

+ virtual v8::Handle<v8::Object> associateWithWrapper(v8::Isolate*, const WrapperTypeInfo*, v8::Handle<v8::Object> wrapper) override;

private:

DOMDataView(PassRefPtr<DataView> dataView, PassRefPtr<DOMArrayBuffer> domArrayBuffer)

« no previous file with comments | « Source/core/dom/DOMArrayBufferView.h ('k') | Source/core/dom/DOMDataView.cpp » ('j') | no next file with comments »