Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Side by Side Diff: Source/core/dom/Node.cpp

Issue 698023005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Node.h ('k') | Source/core/events/MessageEvent.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 2416 matching lines...) Expand 10 before | Expand all | Expand 10 after
2427 2427
2428 ASSERT(!DOMDataStore::containsWrapper(this, isolate)); 2428 ASSERT(!DOMDataStore::containsWrapper(this, isolate));
2429 2429
2430 const WrapperTypeInfo* wrapperType = wrapperTypeInfo(); 2430 const WrapperTypeInfo* wrapperType = wrapperTypeInfo();
2431 2431
2432 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(isolate, creati onContext, wrapperType, this); 2432 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(isolate, creati onContext, wrapperType, this);
2433 if (UNLIKELY(wrapper.IsEmpty())) 2433 if (UNLIKELY(wrapper.IsEmpty()))
2434 return wrapper; 2434 return wrapper;
2435 2435
2436 wrapperType->installConditionallyEnabledProperties(wrapper, isolate); 2436 wrapperType->installConditionallyEnabledProperties(wrapper, isolate);
2437 return associateWithWrapper(wrapperType, wrapper, isolate); 2437 return associateWithWrapper(isolate, wrapperType, wrapper);
2438 } 2438 }
2439 2439
2440 v8::Handle<v8::Object> Node::associateWithWrapper(const WrapperTypeInfo* wrapper Type, v8::Handle<v8::Object> wrapper, v8::Isolate* isolate) 2440 v8::Handle<v8::Object> Node::associateWithWrapper(v8::Isolate* isolate, const Wr apperTypeInfo* wrapperType, v8::Handle<v8::Object> wrapper)
2441 { 2441 {
2442 return V8DOMWrapper::associateObjectWithWrapper(isolate, this, wrapperType, wrapper); 2442 return V8DOMWrapper::associateObjectWithWrapper(isolate, this, wrapperType, wrapper);
2443 } 2443 }
2444 2444
2445 } // namespace blink 2445 } // namespace blink
2446 2446
2447 #ifndef NDEBUG 2447 #ifndef NDEBUG
2448 2448
2449 void showNode(const blink::Node* node) 2449 void showNode(const blink::Node* node)
2450 { 2450 {
2451 if (node) 2451 if (node)
2452 node->showNode(""); 2452 node->showNode("");
2453 } 2453 }
2454 2454
2455 void showTree(const blink::Node* node) 2455 void showTree(const blink::Node* node)
2456 { 2456 {
2457 if (node) 2457 if (node)
2458 node->showTreeForThis(); 2458 node->showTreeForThis();
2459 } 2459 }
2460 2460
2461 void showNodePath(const blink::Node* node) 2461 void showNodePath(const blink::Node* node)
2462 { 2462 {
2463 if (node) 2463 if (node)
2464 node->showNodePathForThis(); 2464 node->showNodePathForThis();
2465 } 2465 }
2466 2466
2467 #endif 2467 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/Node.h ('k') | Source/core/events/MessageEvent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698