Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: Source/core/dom/Document.cpp

Issue 698023005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Document.h ('k') | Source/core/dom/Node.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 8 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 9 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
(...skipping 5756 matching lines...) Expand 10 before | Expand all | Expand 10 after
5767 v8::Handle<v8::Object> wrapper = DOMDataStore::getWrapper(this, isolate) ; 5767 v8::Handle<v8::Object> wrapper = DOMDataStore::getWrapper(this, isolate) ;
5768 if (!wrapper.IsEmpty()) 5768 if (!wrapper.IsEmpty())
5769 return wrapper; 5769 return wrapper;
5770 } 5770 }
5771 5771
5772 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(isolate, creati onContext, wrapperType, this); 5772 v8::Handle<v8::Object> wrapper = V8DOMWrapper::createWrapper(isolate, creati onContext, wrapperType, this);
5773 if (UNLIKELY(wrapper.IsEmpty())) 5773 if (UNLIKELY(wrapper.IsEmpty()))
5774 return wrapper; 5774 return wrapper;
5775 5775
5776 wrapperType->installConditionallyEnabledProperties(wrapper, isolate); 5776 wrapperType->installConditionallyEnabledProperties(wrapper, isolate);
5777 return associateWithWrapper(wrapperType, wrapper, isolate); 5777 return associateWithWrapper(isolate, wrapperType, wrapper);
5778 } 5778 }
5779 5779
5780 v8::Handle<v8::Object> Document::associateWithWrapper(const WrapperTypeInfo* wra pperType, v8::Handle<v8::Object> wrapper, v8::Isolate* isolate) 5780 v8::Handle<v8::Object> Document::associateWithWrapper(v8::Isolate* isolate, cons t WrapperTypeInfo* wrapperType, v8::Handle<v8::Object> wrapper)
5781 { 5781 {
5782 V8DOMWrapper::associateObjectWithWrapper(isolate, this, wrapperType, wrapper ); 5782 V8DOMWrapper::associateObjectWithWrapper(isolate, this, wrapperType, wrapper );
5783 DOMWrapperWorld& world = DOMWrapperWorld::current(isolate); 5783 DOMWrapperWorld& world = DOMWrapperWorld::current(isolate);
5784 if (world.isMainWorld() && frame()) 5784 if (world.isMainWorld() && frame())
5785 frame()->script().windowProxy(world)->updateDocumentWrapper(wrapper); 5785 frame()->script().windowProxy(world)->updateDocumentWrapper(wrapper);
5786 return wrapper; 5786 return wrapper;
5787 } 5787 }
5788 5788
5789 void Document::trace(Visitor* visitor) 5789 void Document::trace(Visitor* visitor)
5790 { 5790 {
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
5851 #ifndef NDEBUG 5851 #ifndef NDEBUG
5852 using namespace blink; 5852 using namespace blink;
5853 void showLiveDocumentInstances() 5853 void showLiveDocumentInstances()
5854 { 5854 {
5855 WeakDocumentSet& set = liveDocumentSet(); 5855 WeakDocumentSet& set = liveDocumentSet();
5856 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 5856 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
5857 for (Document* document : set) 5857 for (Document* document : set)
5858 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data()); 5858 fprintf(stderr, "- Document %p URL: %s\n", document, document->url().str ing().utf8().data());
5859 } 5859 }
5860 #endif 5860 #endif
OLDNEW
« no previous file with comments | « Source/core/dom/Document.h ('k') | Source/core/dom/Node.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698