Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Side by Side Diff: Source/bindings/core/v8/custom/V8MessageEventCustom.cpp

Issue 698023005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 void V8MessageEvent::initMessageEventMethodCustom(const v8::FunctionCallbackInfo <v8::Value>& info) 105 void V8MessageEvent::initMessageEventMethodCustom(const v8::FunctionCallbackInfo <v8::Value>& info)
106 { 106 {
107 ExceptionState exceptionState(ExceptionState::ExecutionContext, "initMessage Event", "MessageEvent", info.Holder(), info.GetIsolate()); 107 ExceptionState exceptionState(ExceptionState::ExecutionContext, "initMessage Event", "MessageEvent", info.Holder(), info.GetIsolate());
108 MessageEvent* event = V8MessageEvent::toImpl(info.Holder()); 108 MessageEvent* event = V8MessageEvent::toImpl(info.Holder());
109 TOSTRING_VOID(V8StringResource<>, typeArg, info[0]); 109 TOSTRING_VOID(V8StringResource<>, typeArg, info[0]);
110 TONATIVE_VOID(bool, canBubbleArg, info[1]->BooleanValue()); 110 TONATIVE_VOID(bool, canBubbleArg, info[1]->BooleanValue());
111 TONATIVE_VOID(bool, cancelableArg, info[2]->BooleanValue()); 111 TONATIVE_VOID(bool, cancelableArg, info[2]->BooleanValue());
112 v8::Handle<v8::Value> dataArg = info[3]; 112 v8::Handle<v8::Value> dataArg = info[3];
113 TOSTRING_VOID(V8StringResource<>, originArg, info[4]); 113 TOSTRING_VOID(V8StringResource<>, originArg, info[4]);
114 TOSTRING_VOID(V8StringResource<>, lastEventIdArg, info[5]); 114 TOSTRING_VOID(V8StringResource<>, lastEventIdArg, info[5]);
115 DOMWindow* sourceArg = toDOMWindow(info[6], info.GetIsolate()); 115 DOMWindow* sourceArg = toDOMWindow(info.GetIsolate(), info[6]);
116 OwnPtrWillBeRawPtr<MessagePortArray> portArray = nullptr; 116 OwnPtrWillBeRawPtr<MessagePortArray> portArray = nullptr;
117 const int portArrayIndex = 7; 117 const int portArrayIndex = 7;
118 if (!isUndefinedOrNull(info[portArrayIndex])) { 118 if (!isUndefinedOrNull(info[portArrayIndex])) {
119 portArray = adoptPtrWillBeNoop(new MessagePortArray); 119 portArray = adoptPtrWillBeNoop(new MessagePortArray);
120 *portArray = toRefPtrWillBeMemberNativeArray<MessagePort, V8MessagePort> (info[portArrayIndex], portArrayIndex + 1, info.GetIsolate(), exceptionState); 120 *portArray = toRefPtrWillBeMemberNativeArray<MessagePort, V8MessagePort> (info[portArrayIndex], portArrayIndex + 1, info.GetIsolate(), exceptionState);
121 if (exceptionState.throwIfNeeded()) 121 if (exceptionState.throwIfNeeded())
122 return; 122 return;
123 } 123 }
124 event->initMessageEvent(typeArg, canBubbleArg, cancelableArg, originArg, las tEventIdArg, sourceArg, portArray.release()); 124 event->initMessageEvent(typeArg, canBubbleArg, cancelableArg, originArg, las tEventIdArg, sourceArg, portArray.release());
125 125
126 if (!dataArg.IsEmpty()) { 126 if (!dataArg.IsEmpty()) {
127 V8HiddenValue::setHiddenValue(info.GetIsolate(), info.Holder(), V8Hidden Value::data(info.GetIsolate()), dataArg); 127 V8HiddenValue::setHiddenValue(info.GetIsolate(), info.Holder(), V8Hidden Value::data(info.GetIsolate()), dataArg);
128 if (DOMWrapperWorld::current(info.GetIsolate()).isIsolatedWorld()) 128 if (DOMWrapperWorld::current(info.GetIsolate()).isIsolatedWorld())
129 event->setSerializedData(SerializedScriptValue::createAndSwallowExce ptions(info.GetIsolate(), dataArg)); 129 event->setSerializedData(SerializedScriptValue::createAndSwallowExce ptions(info.GetIsolate(), dataArg));
130 } 130 }
131 } 131 }
132 132
133 } // namespace blink 133 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698