Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 698023004: Reposition the "invalid password" bubble if the User Manager is resized. (Closed)

Created:
6 years, 1 month ago by noms (inactive)
Modified:
6 years, 1 month ago
Reviewers:
xiyuan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reposition the "invalid password" bubble if the User Manager is resized. BUG=378741 TEST=Start Chrome with --enable-new-profile-management. You'll need to create a supervised user so that Lock is available to signed in profiles. Lock a profile, and in the User Manager type an incorrect password. Once the error bubble shows up, resize the User Manager. The bubble should be repositioned along with its parent pod. Committed: https://crrev.com/da3c4f9c6d8b2c0e62bb25b7a9ef6b82e7903c6a Cr-Commit-Position: refs/heads/master@{#302525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ui/login/account_picker/screen_account_picker.js View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
noms (inactive)
6 years, 1 month ago (2014-11-03 22:47:42 UTC) #2
xiyuan
lgtm
6 years, 1 month ago (2014-11-03 22:49:49 UTC) #3
noms (inactive)
Sweet, thanks!
6 years, 1 month ago (2014-11-03 22:50:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698023004/1
6 years, 1 month ago (2014-11-03 22:53:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-04 00:04:23 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 00:05:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da3c4f9c6d8b2c0e62bb25b7a9ef6b82e7903c6a
Cr-Commit-Position: refs/heads/master@{#302525}

Powered by Google App Engine
This is Rietveld 408576698