Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Issue 698003006: Fix double subtraction of sent_delta on sync tree activation. (Closed)

Created:
6 years, 1 month ago by bokan
Modified:
6 years, 1 month ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, aelias_OOO_until_Jul13
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix double subtraction of sent_delta on sync tree activation. When PushPropertiesTo sets the active layer's delta to delta - sent_delta, LayerImpl attempts to mirror this to the pending twin. However, in doing so it again subtracts pending_delta. This patch saves the sent_delta and clears it before setting the scroll offset and delta on the active layer. BUG=428327 Committed: https://crrev.com/c687507f0c578b06647f82ad3fe574d5615ca049 Cr-Commit-Position: refs/heads/master@{#302709}

Patch Set 1 #

Patch Set 2 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M cc/layers/layer_impl.cc View 1 1 chunk +7 lines, -3 lines 0 comments Download
M cc/layers/layer_impl_unittest.cc View 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bokan
Hi enne, ptal, does this look ok? Alexandre mentioned in (https://codereview.chromium.org/692213002/) that the mirroring shouldn't ...
6 years, 1 month ago (2014-11-03 22:55:45 UTC) #2
bokan
I should note, I'm looking to merge this to M39 so if you could have ...
6 years, 1 month ago (2014-11-03 23:04:13 UTC) #3
enne (OOO)
Yeah, this is a little weird. The pending layer is pushing to the active layer, ...
6 years, 1 month ago (2014-11-04 22:04:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/698003006/20001
6 years, 1 month ago (2014-11-04 22:28:53 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-04 23:41:49 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 23:42:32 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c687507f0c578b06647f82ad3fe574d5615ca049
Cr-Commit-Position: refs/heads/master@{#302709}

Powered by Google App Engine
This is Rietveld 408576698