Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: chromeos/dbus/power_manager_client.cc

Issue 697953002: ObserverList::HasObserver now takes a const pointer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile errors (ChromeOS unit tests). Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chromeos/dbus/power_manager_client.h ('k') | chromeos/dbus/session_manager_client.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/dbus/power_manager_client.h" 5 #include "chromeos/dbus/power_manager_client.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 71
72 virtual void AddObserver(Observer* observer) override { 72 virtual void AddObserver(Observer* observer) override {
73 CHECK(observer); // http://crbug.com/119976 73 CHECK(observer); // http://crbug.com/119976
74 observers_.AddObserver(observer); 74 observers_.AddObserver(observer);
75 } 75 }
76 76
77 virtual void RemoveObserver(Observer* observer) override { 77 virtual void RemoveObserver(Observer* observer) override {
78 observers_.RemoveObserver(observer); 78 observers_.RemoveObserver(observer);
79 } 79 }
80 80
81 virtual bool HasObserver(Observer* observer) override { 81 virtual bool HasObserver(const Observer* observer) const override {
82 return observers_.HasObserver(observer); 82 return observers_.HasObserver(observer);
83 } 83 }
84 84
85 virtual void DecreaseScreenBrightness(bool allow_off) override { 85 virtual void DecreaseScreenBrightness(bool allow_off) override {
86 dbus::MethodCall method_call( 86 dbus::MethodCall method_call(
87 power_manager::kPowerManagerInterface, 87 power_manager::kPowerManagerInterface,
88 power_manager::kDecreaseScreenBrightnessMethod); 88 power_manager::kDecreaseScreenBrightnessMethod);
89 dbus::MessageWriter writer(&method_call); 89 dbus::MessageWriter writer(&method_call);
90 writer.AppendBool(allow_off); 90 writer.AppendBool(allow_off);
91 power_manager_proxy_->CallMethod( 91 power_manager_proxy_->CallMethod(
(...skipping 681 matching lines...) Expand 10 before | Expand all | Expand 10 after
773 } 773 }
774 774
775 virtual void AddObserver(Observer* observer) override { 775 virtual void AddObserver(Observer* observer) override {
776 observers_.AddObserver(observer); 776 observers_.AddObserver(observer);
777 } 777 }
778 778
779 virtual void RemoveObserver(Observer* observer) override { 779 virtual void RemoveObserver(Observer* observer) override {
780 observers_.RemoveObserver(observer); 780 observers_.RemoveObserver(observer);
781 } 781 }
782 782
783 virtual bool HasObserver(Observer* observer) override { 783 virtual bool HasObserver(const Observer* observer) const override {
784 return observers_.HasObserver(observer); 784 return observers_.HasObserver(observer);
785 } 785 }
786 786
787 virtual void DecreaseScreenBrightness(bool allow_off) override { 787 virtual void DecreaseScreenBrightness(bool allow_off) override {
788 VLOG(1) << "Requested to descrease screen brightness"; 788 VLOG(1) << "Requested to descrease screen brightness";
789 SetBrightness(brightness_ - 5.0, true); 789 SetBrightness(brightness_ - 5.0, true);
790 } 790 }
791 791
792 virtual void IncreaseScreenBrightness() override { 792 virtual void IncreaseScreenBrightness() override {
793 VLOG(1) << "Requested to increase screen brightness"; 793 VLOG(1) << "Requested to increase screen brightness";
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
970 // static 970 // static
971 PowerManagerClient* PowerManagerClient::Create( 971 PowerManagerClient* PowerManagerClient::Create(
972 DBusClientImplementationType type) { 972 DBusClientImplementationType type) {
973 if (type == REAL_DBUS_CLIENT_IMPLEMENTATION) 973 if (type == REAL_DBUS_CLIENT_IMPLEMENTATION)
974 return new PowerManagerClientImpl(); 974 return new PowerManagerClientImpl();
975 DCHECK_EQ(STUB_DBUS_CLIENT_IMPLEMENTATION, type); 975 DCHECK_EQ(STUB_DBUS_CLIENT_IMPLEMENTATION, type);
976 return new PowerManagerClientStubImpl(); 976 return new PowerManagerClientStubImpl();
977 } 977 }
978 978
979 } // namespace chromeos 979 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/dbus/power_manager_client.h ('k') | chromeos/dbus/session_manager_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698