ObserverList::HasObserver now takes a const pointer.

ObserverList::HasObserver now takes a const pointer.

Updated all clients that wrap HasObserver and expose it to also take a
const pointer. This change avoids further propagation of non-constness
(which was previously required when using HasObserver methods).

BUG=429588
TBR=michaeln@chromium.org,nyquist@chromium.org,pkotwicz@chromium.org,satorux@chromium.org,sky@chromium.org,zea@chromium.org

Committed: https://crrev.com/64ccf236e6657cf0a85506c56d4ba226fdea4765
Cr-Commit-Position: refs/heads/master@{#303428}

[Matt Giuca, 2014-11-03 23:21:58]

mgiuca@chromium.org changed reviewers:
+ calamity@chromium.org, michaeln@chromium.org, thestig@chromium.org

[Matt Giuca, 2014-11-03 23:21:58]

mgiuca@chromium.org changed required reviewers:
+ thestig@chromium.org

[Matt Giuca, 2014-11-03 23:22:00]

Hi reviewers,

This is a fairly big change in terms of the number of files it touches, but I
think it is worth putting a stop to the mindless propagation of non-const
pointers required to call HasObserver. (I recently had make a method in a
completely unrelated class return a non-const pointer just to call HasObserver,
which is what triggered me to do this.)

thestig: base/observer_list.h
michaeln: content/browser/appcache/appcache_group (note that I changed a method
to static there).
calamity: ui/app_list/app_list_model_unittest.cc (note that I changed a method
to static there).

I will TBR the remaining changes as they are mechanical in nature.

https://codereview.chromium.org/697953002/diff/1/content/browser/appcache/app...
File content/browser/appcache/appcache_group.h (right):

https://codereview.chromium.org/697953002/diff/1/content/browser/appcache/app...
content/browser/appcache/appcache_group.h:125: static bool FindObserver(const
UpdateObserver* find_me,
Note: I made this static as well (unrelated, but it should be static).

https://codereview.chromium.org/697953002/diff/1/ui/app_list/app_list_model_u...
File ui/app_list/app_list_model_unittest.cc (right):

https://codereview.chromium.org/697953002/diff/1/ui/app_list/app_list_model_u...
ui/app_list/app_list_model_unittest.cc:78: static bool
ItemObservedByFolder(const AppListFolderItem* folder,
Note: I made this static as well (unrelated, but it should be static).

[Matt Giuca, 2014-11-03 23:23:34]

mgiuca@chromium.org changed reviewers:
- calamity@chromium.org

[Matt Giuca, 2014-11-03 23:23:35]

calamity: Actually, you are not required as I am an OWNER in ui/app_list.

[Lei Zhang, 2014-11-03 23:43:03]

lgtm

[Matt Giuca, 2014-11-04 00:08:08]

Thanks for the fast response. I will wait until after branch point (Friday) to
avoid unnecessary conflicts with other people.

[Matt Giuca, 2014-11-10 02:45:21]

mgiuca@chromium.org changed reviewers:
+ nyquist@chromium.org, pkotwicz@chromium.org, satorux@chromium.org,
sky@chromium.org, zea@chromium.org

[Matt Giuca, 2014-11-10 02:45:21]

Adding TBR reviewers for OWNERS (mechanical change):
- michaeln: content/browser/appcache/*
- nyquist: components/invalidation/*
- pkotwicz: ash/wm/*
- satorux: chromeos/dbus/*
- sky: ui/*
- zea: sync/sessions/*

[Matt Giuca, 2014-11-10 02:45:36]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-11-10 02:46:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/697953002/40001

[commit-bot: I haz the power, 2014-11-10 03:23:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-10 03:23:42]

Try jobs failed on following builders:
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Matt Giuca, 2014-11-10 04:57:08]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-11-10 04:58:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/697953002/60001

[commit-bot: I haz the power, 2014-11-10 05:34:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-10 05:34:07]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Matt Giuca, 2014-11-10 05:36:40]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2014-11-10 05:37:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/697953002/80001

[commit-bot: I haz the power, 2014-11-10 06:44:37]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-11-10 06:45:15]

Patchset 5 (id:??) landed as
https://crrev.com/64ccf236e6657cf0a85506c56d4ba226fdea4765
Cr-Commit-Position: refs/heads/master@{#303428}