Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 69793004: Revert 234367 "Base: Make RegistryOverrideManager support sharde..." (Closed)

Created:
7 years, 1 month ago by tommycli
Modified:
7 years, 1 month ago
Reviewers:
tommycli
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 234367 "Base: Make RegistryOverrideManager support sharde..." > Base: Make RegistryOverrideManager support sharded/parallel tests. > > BUG=314800 > TBR=ajwong@chromium.org > > Review URL: https://codereview.chromium.org/57423008 TBR=tommycli@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -239 lines) Patch
M trunk/src/base/base.gyp View 2 chunks +2 lines, -1 line 0 comments Download
M trunk/src/base/test/test_reg_util_win.h View 1 chunk +20 lines, -35 lines 0 comments Download
M trunk/src/base/test/test_reg_util_win.cc View 2 chunks +31 lines, -68 lines 0 comments Download
D trunk/src/base/test/test_reg_util_win_unittest.cc View 1 chunk +0 lines, -130 lines 0 comments Download
M trunk/src/chrome/installer/gcapi/gcapi_test_registry_overrider.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M trunk/src/chrome/installer/setup/setup_util_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/chrome/installer/util/product_state_unittest.cc View 4 chunks +17 lines, -3 lines 0 comments Download
M trunk/src/chrome_frame/test/chrome_frame_test_utils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/chrome_frame/test/chrome_frame_test_utils.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M trunk/src/chrome_frame/test/util_unittests.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tommycli
7 years, 1 month ago (2013-11-12 20:37:54 UTC) #1
tommycli
Committed patchset #1 manually as r234627.
7 years, 1 month ago (2013-11-12 20:38:09 UTC) #2
grt (UTC plus 2)
Thanks. If you don't beat me to it, I have a change underway to fix ...
7 years, 1 month ago (2013-11-12 20:45:13 UTC) #3
tommycli
7 years, 1 month ago (2013-11-12 21:18:52 UTC) #4
Message was sent while issue was closed.
On 2013/11/12 20:45:13, grt wrote:
> Thanks. If you don't beat me to it, I have a change underway to fix RLZ's
tests
> to use the override manager in a sane way. Unfortunately, it's a bigger job
than
> I thought so I won't have it ready for a little while yet. I'll send a CR your
> way in a bit.

Oh okay cool. Yeah I reverted it due to the RLZ tests.

I haven't done anything with the RLZ tests yet, so I'm happy to provide a review
for you.

Powered by Google App Engine
This is Rietveld 408576698