Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 697903002: Fix some minor typos related to the word "accessibility". (Closed)

Created:
6 years, 1 month ago by Sungmann Cho
Modified:
6 years, 1 month ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, dtseng+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, yukishiino+watch_chromium.org, aboxhall+watch_chromium.org, jam, extensions-reviews_chromium.org, yuzo+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, yusukes+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, stevenjb+watch_chromium.org, plundblad+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix some minor typos related to the word "accessibility". BUG=none TBR=asargent Committed: https://crrev.com/e8f9c11c1d887a2768fe31a94ccca273baa1b0ff Cr-Commit-Position: refs/heads/master@{#302528}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Revert the changes of chrome/test/data/page_cycler/cached_data_dir/Default/Cache/f_00001c #

Patch Set 5 : Fix an error of the chromeos build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M ash/ash_chromeos_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/power/tray_power.cc View 1 2 3 4 3 chunks +8 lines, -8 lines 0 comments Download
M ash/system/tray_accessibility.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chromeos_strings.grdp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/pdf/pdf_scripting_api.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/screenlock_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/language_options_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/automation_internal.idl View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/api/virtual_keyboard_private.json View 1 chunk +1 line, -1 line 0 comments Download
M ui/keyboard/resources/elements/kb-keyboard.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (9 generated)
Sungmann Cho
Please take a look. Thanks!
6 years, 1 month ago (2014-11-03 01:36:15 UTC) #2
dmazzoni
lgtm
6 years, 1 month ago (2014-11-03 16:30:29 UTC) #3
dmazzoni
+sky for chrome/ and ash/ +asargent for extensions/
6 years, 1 month ago (2014-11-03 16:33:07 UTC) #5
sky
LGTM
6 years, 1 month ago (2014-11-03 16:55:00 UTC) #6
dmazzoni
TBR:asargent since this is trivial
6 years, 1 month ago (2014-11-03 17:04:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697903002/20001
6 years, 1 month ago (2014-11-03 17:05:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/76953) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/30086) android_arm64_dbg_recipe ...
6 years, 1 month ago (2014-11-03 17:09:23 UTC) #11
asargent_no_longer_on_chrome
Hopefully when the computers write the code for us we won't have these kinds of ...
6 years, 1 month ago (2014-11-03 17:55:24 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697903002/40001
6 years, 1 month ago (2014-11-03 22:58:48 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697903002/60001
6 years, 1 month ago (2014-11-03 23:10:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697903002/80001
6 years, 1 month ago (2014-11-03 23:28:07 UTC) #20
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years, 1 month ago (2014-11-04 00:20:15 UTC) #21
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 00:21:03 UTC) #22
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/e8f9c11c1d887a2768fe31a94ccca273baa1b0ff
Cr-Commit-Position: refs/heads/master@{#302528}

Powered by Google App Engine
This is Rietveld 408576698