Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: Source/core/css/StyleSheetList.h

Issue 697893003: Oilpan: avoid invoking some no-op finalizers. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: compile fix Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/MediaQueryListListener.cpp ('k') | Source/core/css/StyleSheetList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/StyleSheetList.h
diff --git a/Source/core/css/StyleSheetList.h b/Source/core/css/StyleSheetList.h
index a34b0808ab4974f4d39488f232dd6fd019964f7b..70f24c8ff9b1d33920624894cd638ac283a53ed0 100644
--- a/Source/core/css/StyleSheetList.h
+++ b/Source/core/css/StyleSheetList.h
@@ -34,11 +34,11 @@ namespace blink {
class HTMLStyleElement;
class StyleSheet;
-class StyleSheetList : public RefCountedWillBeGarbageCollectedFinalized<StyleSheetList>, public ScriptWrappable {
+class StyleSheetList final : public RefCountedWillBeGarbageCollectedFinalized<StyleSheetList>, public ScriptWrappable {
haraken 2014/11/12 14:39:01 RefCountedWillBeGarbageCollectedFinalized => RefCo
sof 2014/11/12 14:48:11 Not unless we alter the plugin to insist that Fina
+ DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(StyleSheetList);
DEFINE_WRAPPERTYPEINFO();
public:
static PassRefPtrWillBeRawPtr<StyleSheetList> create(TreeScope* treeScope) { return adoptRefWillBeNoop(new StyleSheetList(treeScope)); }
- ~StyleSheetList();
unsigned length();
StyleSheet* item(unsigned index);
@@ -56,7 +56,7 @@ public:
void trace(Visitor*);
private:
- StyleSheetList(TreeScope*);
+ explicit StyleSheetList(TreeScope*);
const WillBeHeapVector<RefPtrWillBeMember<StyleSheet> >& styleSheets();
RawPtrWillBeMember<TreeScope> m_treeScope;
« no previous file with comments | « Source/core/css/MediaQueryListListener.cpp ('k') | Source/core/css/StyleSheetList.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698