Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 697893002: clang-format/java: Tweak style a bit. (Closed)

Created:
6 years, 1 month ago by Nico
Modified:
6 years, 1 month ago
Reviewers:
cjhopman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

clang-format/java: Tweak style a bit. Based on formatting a few java files in base/ and comparing before/after. BUG=429372 NOTRY=true Committed: https://crrev.com/4ad85931d0517410d5dee0870e6eecae8e38136a Cr-Commit-Position: refs/heads/master@{#302406}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M .clang-format View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Nico
6 years, 1 month ago (2014-11-02 22:21:14 UTC) #2
cjhopman
https://codereview.chromium.org/697893002/diff/1/.clang-format File .clang-format (right): https://codereview.chromium.org/697893002/diff/1/.clang-format#newcode17 .clang-format:17: AllowShortFunctionsOnASingleLine: false Should the value here be one of ...
6 years, 1 month ago (2014-11-02 22:48:35 UTC) #3
Nico
https://codereview.chromium.org/697893002/diff/1/.clang-format File .clang-format (right): https://codereview.chromium.org/697893002/diff/1/.clang-format#newcode17 .clang-format:17: AllowShortFunctionsOnASingleLine: false On 2014/11/02 22:48:35, cjhopman wrote: > Should ...
6 years, 1 month ago (2014-11-02 23:07:53 UTC) #4
cjhopman
lgtm
6 years, 1 month ago (2014-11-02 23:32:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697893002/20001
6 years, 1 month ago (2014-11-02 23:36:50 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-02 23:37:16 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-02 23:38:01 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4ad85931d0517410d5dee0870e6eecae8e38136a
Cr-Commit-Position: refs/heads/master@{#302406}

Powered by Google App Engine
This is Rietveld 408576698