Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 697873007: Add Module and Application interfaces (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Add Module and Application interfaces These interfaces are currently unused by the engine, but they are constructable. See apis.md for details. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2b7b15ef781f56bcd8cffd1e3092eb991f9270ae

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -10 lines) Patch
A sky/engine/core/app/AbstractModule.h View 1 chunk +38 lines, -0 lines 2 comments Download
A sky/engine/core/app/AbstractModule.cpp View 1 chunk +26 lines, -0 lines 0 comments Download
A sky/engine/core/app/AbstractModule.idl View 1 chunk +12 lines, -0 lines 0 comments Download
A sky/engine/core/app/Application.h View 1 chunk +34 lines, -0 lines 2 comments Download
A sky/engine/core/app/Application.cpp View 1 chunk +26 lines, -0 lines 0 comments Download
A + sky/engine/core/app/Application.idl View 1 chunk +4 lines, -3 lines 0 comments Download
A sky/engine/core/app/Module.h View 1 chunk +39 lines, -0 lines 2 comments Download
A sky/engine/core/app/Module.cpp View 1 chunk +27 lines, -0 lines 0 comments Download
A sky/engine/core/app/Module.idl View 1 chunk +11 lines, -0 lines 0 comments Download
M sky/engine/core/core.gni View 2 chunks +9 lines, -0 lines 0 comments Download
M sky/engine/core/events/EventTargetFactory.in View 1 chunk +2 lines, -1 line 0 comments Download
A + sky/tests/modules/application.sky View 1 chunk +4 lines, -5 lines 0 comments Download
A sky/tests/modules/application-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A sky/tests/modules/modules.sky View 1 chunk +18 lines, -0 lines 0 comments Download
A + sky/tests/modules/modules-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
eseidel
6 years, 1 month ago (2014-11-10 21:45:49 UTC) #2
eseidel
https://codereview.chromium.org/697873007/diff/1/sky/engine/core/app/AbstractModule.h File sky/engine/core/app/AbstractModule.h (right): https://codereview.chromium.org/697873007/diff/1/sky/engine/core/app/AbstractModule.h#newcode32 sky/engine/core/app/AbstractModule.h:32: RefPtr<Document> m_document; document_
6 years, 1 month ago (2014-11-10 21:46:45 UTC) #3
eseidel
lgtm c++ looks fine https://codereview.chromium.org/697873007/diff/1/sky/engine/core/app/Application.h File sky/engine/core/app/Application.h (right): https://codereview.chromium.org/697873007/diff/1/sky/engine/core/app/Application.h#newcode22 sky/engine/core/app/Application.h:22: void setTitle(const String& title) { ...
6 years, 1 month ago (2014-11-10 22:02:00 UTC) #4
abarth-chromium
https://codereview.chromium.org/697873007/diff/1/sky/engine/core/app/AbstractModule.h File sky/engine/core/app/AbstractModule.h (right): https://codereview.chromium.org/697873007/diff/1/sky/engine/core/app/AbstractModule.h#newcode32 sky/engine/core/app/AbstractModule.h:32: RefPtr<Document> m_document; On 2014/11/10 at 21:46:45, eseidel wrote: > ...
6 years, 1 month ago (2014-11-10 22:14:21 UTC) #5
abarth-chromium
6 years, 1 month ago (2014-11-10 22:17:00 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
2b7b15ef781f56bcd8cffd1e3092eb991f9270ae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698