Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(95)

Issue 697863002: Pass in long to XChangeProperty() instead of an int when using format=32 (Closed)

Created:
6 years, 1 month ago by pkotwicz
Modified:
6 years, 1 month ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Pass in long to XChangeProperty() instead of an int when using format=32 BUG=428557 TEST=None Committed: https://crrev.com/f09a3116b3c3bff8d4c98dd65d659471a7eeff6f Cr-Commit-Position: refs/heads/master@{#302404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/base/x/selection_owner.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
pkotwicz
Elliot, PTAL
6 years, 1 month ago (2014-11-02 03:28:31 UTC) #2
Daniel Erat
lgtm xlib, the gift that keeps giving.
6 years, 1 month ago (2014-11-02 13:49:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697863002/1
6 years, 1 month ago (2014-11-02 21:45:04 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-02 22:24:57 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-02 22:25:36 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f09a3116b3c3bff8d4c98dd65d659471a7eeff6f
Cr-Commit-Position: refs/heads/master@{#302404}

Powered by Google App Engine
This is Rietveld 408576698