Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 697843005: Rebaseline compositing/images/direct-image-dynamic-clip-path.html (Closed)

Created:
6 years, 1 month ago by Noel Gordon
Modified:
6 years, 1 month ago
Reviewers:
yhirano
CC:
blink-reviews, senorblanco, dstockwell, yosin_UTC9
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Rebaseline compositing/images/direct-image-dynamic-clip-path.html Delete mac result, rebaseline to grab any new mac result, which should match the windows result and be optimized out if things are working as expected per issue 405803 and issue 409435. BUG=405803 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185102 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185184 Mac bots did not cycle green after auto-rebaselines for r185184 landed so I reverted. Revert was: Revert: https://src.chromium.org/viewvc/blink?view=rev&revision=185202

Patch Set 1 #

Patch Set 2 : Patch for relanding now the mac bots are stable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +1 line, -0 lines 0 comments Download
D LayoutTests/platform/mac/compositing/images/direct-image-clip-path-expected.png View Binary file 0 comments Download

Messages

Total messages: 20 (3 generated)
Noel Gordon
Let's try.
6 years, 1 month ago (2014-11-11 04:55:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697843005/1
6 years, 1 month ago (2014-11-11 04:56:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 185102
6 years, 1 month ago (2014-11-11 04:56:48 UTC) #4
Noel Gordon
No tmp space issue on 10.8 mac bot https://code.google.com/p/chromium/issues/detail?id=432058, which prevents rebaseline-o-matic from running. Will ...
6 years, 1 month ago (2014-11-11 11:17:38 UTC) #5
Noel Gordon
Same issue yhirano mentioned, can't revert from code review tool.
6 years, 1 month ago (2014-11-11 11:21:17 UTC) #6
Noel Gordon
On 2014/11/11 11:21:17, noel gordon wrote: > Same issue yhirano mentioned, can't revert from code ...
6 years, 1 month ago (2014-11-11 11:32:28 UTC) #7
Noel Gordon
https://codereview.chromium.org/694123004
6 years, 1 month ago (2014-11-11 11:33:51 UTC) #8
Noel Gordon
On 2014/11/11 11:33:51, noel gordon wrote: > https://codereview.chromium.org/694123004 Submitted.
6 years, 1 month ago (2014-11-11 11:39:00 UTC) #9
Noel Gordon
6 years, 1 month ago (2014-11-12 06:34:43 UTC) #11
Noel Gordon
yhirano@ does this look good to you. The mac bots seem in a good state ...
6 years, 1 month ago (2014-11-12 06:41:29 UTC) #12
yhirano
lgtm
6 years, 1 month ago (2014-11-12 06:42:11 UTC) #13
Noel Gordon
+yosin who is gardening. yosin this CL might break compositing/images/direct-image-dynamic-clip-path.html on Mac until rebaseline-o-matic submits ...
6 years, 1 month ago (2014-11-12 06:47:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697843005/20001
6 years, 1 month ago (2014-11-12 06:48:22 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 185184
6 years, 1 month ago (2014-11-12 06:48:58 UTC) #17
Noel Gordon
Rebaseline landed in https://src.chromium.org/viewvc/blink?view=rev&revision=185193 but the bots did not cycle green. Seems the fallback path ...
6 years, 1 month ago (2014-11-12 11:30:35 UTC) #18
Noel Gordon
Revert in https://codereview.chromium.org/717113002/
6 years, 1 month ago (2014-11-12 11:55:13 UTC) #19
Noel Gordon
6 years, 1 month ago (2014-11-12 11:56:07 UTC) #20
Message was sent while issue was closed.
Revert committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185202

Powered by Google App Engine
This is Rietveld 408576698