Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2734)

Unified Diff: chrome/test/chromedriver/chrome/devtools_http_client.cc

Issue 697843003: [chromedriver] Use CloseWebView() to close DevTools UI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/devtools_http_client.cc
diff --git a/chrome/test/chromedriver/chrome/devtools_http_client.cc b/chrome/test/chromedriver/chrome/devtools_http_client.cc
index 7f3a49e9f134a84bcc6988b02f00c09dec90a72a..b49c3a39a8bf9543e3b6f244035e95adfb6493f6 100644
--- a/chrome/test/chromedriver/chrome/devtools_http_client.cc
+++ b/chrome/test/chromedriver/chrome/devtools_http_client.cc
@@ -191,10 +191,7 @@ Status DevToolsHttpClient::CloseFrontends(const std::string& for_client_id) {
return status;
scoped_ptr<base::Value> result;
- status = web_view->EvaluateScript(
- std::string(),
- "document.querySelector('*[id^=\"close-button-\"]').click();",
- &result);
+ status = CloseWebView(*it);
// Ignore disconnected error, because it may be closed already.
if (status.IsError() && status.code() != kDisconnected)
return status;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698