Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 697823002: OnSwapBuffersComplete in GpuSurfacelessBrowserCompositorOutputSurface is never called. (Closed)

Created:
6 years, 1 month ago by kalyank
Modified:
6 years, 1 month ago
Reviewers:
no sievers, ccameron
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

OnSwapBuffersComplete in GpuSurfacelessBrowserCompositorOutputSurface is never called. In OnSwapBuffersComplete we call PageFlipComplete in BufferQueue, which ensures the buffers are recycled properly. However, GpuSurfacelessBrowserCompositorOutputSurface::OnSwapBuffersComplete is never called as GpuBrowserCompositorOutputSurface directly calls the base class implementation. This CL fixes it. BUG=380861 Committed: https://crrev.com/4c65a7f95d9d37808d89c586d5f1a47147cb67db Cr-Commit-Position: refs/heads/master@{#302479}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/compositor/gpu_browser_compositor_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
kalyank
6 years, 1 month ago (2014-11-01 13:20:42 UTC) #2
no sievers
lgtm
6 years, 1 month ago (2014-11-03 18:32:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697823002/1
6 years, 1 month ago (2014-11-03 19:34:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-03 21:13:51 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 21:14:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c65a7f95d9d37808d89c586d5f1a47147cb67db
Cr-Commit-Position: refs/heads/master@{#302479}

Powered by Google App Engine
This is Rietveld 408576698