Use a stub implementation of GlobalShortcutListener for Athena

Use a stub implementation of GlobalShortcutListener for Athena

BUG=426561
TEST=None

Committed: https://crrev.com/3064611cafd0464e4899dfdf7f485efe71f3ef57
Cr-Commit-Position: refs/heads/master@{#302578}

[pkotwicz, 2014-11-01 02:23:22]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2014-11-01 02:29:12]

pkotwicz@chromium.org changed reviewers:
+ oshima@chromium.org

[pkotwicz, 2014-11-01 02:29:13]

Oshima, PTAL

Eventually, we should delete this class and compile out all of the files used
for the commands extension API (and other extension APIs that are not enabled on
Athena)

https://codereview.chromium.org/697803002/diff/20001/chrome/chrome_browser_ex...
File chrome/chrome_browser_extensions.gypi (left):

https://codereview.chromium.org/697803002/diff/20001/chrome/chrome_browser_ex...
chrome/chrome_browser_extensions.gypi:702:
'browser/extensions/global_shortcut_listener_x11.h',
Scarily enough GlobalShortcutListenerX11 was being compiled on ChromeOS. We need
to eventually get the compiler to catch bugs like this.

[oshima, 2014-11-03 21:34:59]

lgtm

https://codereview.chromium.org/697803002/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/global_shortcut_listener_athena.cc (right):

https://codereview.chromium.org/697803002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/global_shortcut_listener_athena.cc:1: // Copyright
2013 The Chromium Authors. All rights reserved.
nit: 2014

[pkotwicz, 2014-11-03 21:59:33]

Patchset #2 (id:40001) has been deleted

[pkotwicz, 2014-11-03 22:05:40]

Patchset #2 (id:60001) has been deleted

[pkotwicz, 2014-11-03 22:06:07]

pkotwicz@chromium.org changed reviewers:
+ asargent@chromium.org

[pkotwicz, 2014-11-03 22:06:08]

asargent@ for OWNERS

[asargent_no_longer_on_chrome, 2014-11-03 23:22:49]

lgtm

[pkotwicz, 2014-11-04 01:43:03]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-11-04 01:46:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/697803002/80001

[commit-bot: I haz the power, 2014-11-04 01:55:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-04 01:55:36]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/77213)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/82171)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[pkotwicz, 2014-11-04 03:51:40]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-11-04 03:52:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/697803002/100001

[commit-bot: I haz the power, 2014-11-04 05:59:51]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2014-11-04 06:00:32]

Patchset 3 (id:??) landed as
https://crrev.com/3064611cafd0464e4899dfdf7f485efe71f3ef57
Cr-Commit-Position: refs/heads/master@{#302578}

[tzik, 2014-11-04 06:20:36]

A revert of this CL (patchset #3 id:100001) has been created in
https://codereview.chromium.org/697343002/ by tzik@chromium.org.

The reason for reverting is: This CL breaks GN build on ChromeOS:
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20C...

The error message was:
ERROR at //chrome/browser/extensions/BUILD.gn:189:7: Item not found
      "global_shortcut_listener_x11.cc",
      ^--------------------------------
You were trying to remove "global_shortcut_listener_x11.cc"
from the list but it wasn't there.
.