Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 697783002: Experiment with clang-format for android java files. (Closed)

Created:
6 years, 1 month ago by Nico
Modified:
6 years, 1 month ago
Reviewers:
cjhopman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Experiment with clang-format for android java files. BUG=429372 NOTRY=true Committed: https://crrev.com/ff9bdbdb3a3957aaa2779110508732980a34f128 Cr-Commit-Position: refs/heads/master@{#302358}

Patch Set 1 #

Patch Set 2 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M .clang-format View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Nico
6 years, 1 month ago (2014-10-31 23:47:38 UTC) #2
cjhopman
lgtm
6 years, 1 month ago (2014-10-31 23:54:39 UTC) #3
Nico
(I added 2 more lines based on https://source.android.com/source/code-style.html a few seconds before you lgtm'd, I'll ...
6 years, 1 month ago (2014-10-31 23:56:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697783002/20001
6 years, 1 month ago (2014-10-31 23:58:17 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-31 23:59:15 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 23:59:46 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ff9bdbdb3a3957aaa2779110508732980a34f128
Cr-Commit-Position: refs/heads/master@{#302358}

Powered by Google App Engine
This is Rietveld 408576698