Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 697773004: DevTools: [CSS] report matched selectors for pseudoId matches (Closed)

Created:
6 years, 1 month ago by lushnikov
Modified:
6 years, 1 month ago
Reviewers:
apavlov, vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: [CSS] report matched selectors for pseudoId matches The patch fixes CSS.getMatchedStylesForNode protocol method so that it starts to report matched selectors for pseudo style matches. R=vsevik, apavlov Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184857

Patch Set 1 #

Total comments: 6

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M LayoutTests/inspector/elements/elements-panel-styles-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/pseudo-elements.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/elements/styles/pseudo-elements-expected.txt View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 5 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
lushnikov
Please, take a look
6 years, 1 month ago (2014-11-04 12:43:38 UTC) #1
vsevik
lgtm https://codereview.chromium.org/697773004/diff/1/LayoutTests/inspector/elements/styles/pseudo-elements-expected.txt File LayoutTests/inspector/elements/styles/pseudo-elements-expected.txt (right): https://codereview.chromium.org/697773004/diff/1/LayoutTests/inspector/elements/styles/pseudo-elements-expected.txt#newcode31 LayoutTests/inspector/elements/styles/pseudo-elements-expected.txt:31: [$#inspected:before$] { (pseudo-elements.html:4 -> pseudo-elements.html:4:1) Let's put two ...
6 years, 1 month ago (2014-11-05 07:09:26 UTC) #2
lushnikov
https://codereview.chromium.org/697773004/diff/1/LayoutTests/inspector/elements/styles/pseudo-elements-expected.txt File LayoutTests/inspector/elements/styles/pseudo-elements-expected.txt (right): https://codereview.chromium.org/697773004/diff/1/LayoutTests/inspector/elements/styles/pseudo-elements-expected.txt#newcode31 LayoutTests/inspector/elements/styles/pseudo-elements-expected.txt:31: [$#inspected:before$] { (pseudo-elements.html:4 -> pseudo-elements.html:4:1) On 2014/11/05 07:09:26, vsevik ...
6 years, 1 month ago (2014-11-05 07:41:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/697773004/20001
6 years, 1 month ago (2014-11-05 07:41:23 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 08:41:35 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 184857

Powered by Google App Engine
This is Rietveld 408576698