Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 697763002: Adds dependency on sanitizer (Closed)

Created:
6 years, 1 month ago by sky
Modified:
6 years, 1 month ago
Reviewers:
brettw, danno
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Adds dependency on sanitizer The santizer target is empty if no sanitizers are defined, otherwise it contains the necessary targets. Because of this we can always depend on it. Without this dep asan builds fail. R=brettw@chromium.org, danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25094

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sky
Danno, I have no access to the v8 repo. If you approve of this could ...
6 years, 1 month ago (2014-10-31 20:49:13 UTC) #1
brettw
lgtm
6 years, 1 month ago (2014-11-04 05:26:07 UTC) #2
danno
lgtm
6 years, 1 month ago (2014-11-04 08:22:59 UTC) #3
danno
Committed patchset #1 (id:1) manually as 25094 (presubmit successful).
6 years, 1 month ago (2014-11-04 08:27:56 UTC) #4
danno
6 years, 1 month ago (2014-11-04 08:28:09 UTC) #5
Message was sent while issue was closed.
Landed on V8 bleeding_edge

Powered by Google App Engine
This is Rietveld 408576698