sky/services/inspector/BUILD.gn - Issue 697733002: Add a PRESUBMIT for gn check, currently only for //sky/*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/services/inspector/BUILD.gn

Issue 697733002: Add a PRESUBMIT for gn check, currently only for //sky/* (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Actually run the presubmit check Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/services/inspector/BUILD.gn

diff --git a/sky/services/inspector/BUILD.gn b/sky/services/inspector/BUILD.gn

index 4fa90e070e10255c9ae957813a743e6ff1e5e4bb..e2b11f2a8676851d647e5480fc96ec5b3c7dfb50 100644

--- a/sky/services/inspector/BUILD.gn

+++ b/sky/services/inspector/BUILD.gn

@@ -25,6 +25,7 @@ shared_library("sky_inspector_server") {

"//mojo/public/c/system:for_shared_library",

"//mojo/public/cpp/bindings",

"//mojo/public/cpp/utility",

+ "//net",

jamesr 2014/10/31 19:57:45 oh yuck - what do you depend on //net for?

"//net:http_server",

":bindings",

]

« PRESUBMIT.py ('K') | « sky/engine/wtf/BUILD.gn ('k') | no next file » | no next file with comments »