Add a PRESUBMIT for gn check, currently only for //sky/*

PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
@@ skipping 394 matching lines @@
   # Outsource work to gclient verify
   try:
     input_api.subprocess.check_output(['gclient', 'verify'])
     return []
   except input_api.subprocess.CalledProcessError, error:
     return [output_api.PresubmitError(
         'DEPS file must have only git dependencies.',
         long_text=error.output)]
 
 
+def _CheckGNCheck(input_api, output_api):
+  """Checks that gn gen and gn check pass"""
+  # TODO(eseidel): We should not have to pass dir= here but unfortunately

[jamesr, 2014/10/31 19:57:45]

could this be a bug? or do we have a bug?

+  # build/config/clang/BUILD.gn:19 rebase_path can't handle absolute paths!
+  temp_dir = input_api.change.RepositoryRoot()
+  out_dir = input_api.tempfile.mkdtemp(dir=temp_dir)
+  relative_out_dir = input_api.os_path.relpath(out_dir)
+  try:
+    input_api.subprocess.check_output(['gn', 'gen', relative_out_dir])
+  except input_api.subprocess.CalledProcessError, error:
+    return [output_api.PresubmitError(
+        'gn gen must not fail.', long_text=error.output)]
+
+  try:
+    # TODO(eseidel): Currently only //sky/* are known to pass.
+    input_api.subprocess.check_output(['gn', 'check', relative_out_dir,
+        '//sky/*'])

[jamesr, 2014/10/31 19:57:45]

can we make this a list somewhere? i made //mojo/public/* pass a while ago and
i'd like to add that

+  except input_api.subprocess.CalledProcessError, error:
+    return [output_api.PresubmitError(
+        'gn check must not fail.', long_text=error.output)]
+  return []
+
+
 def _CheckNoBannedFunctions(input_api, output_api):
   """Make sure that banned functions are not used."""
   warnings = []
   errors = []
 
   file_filter = lambda f: f.LocalPath().endswith(('.mm', '.m', '.h'))
   for f in input_api.AffectedFiles(file_filter=file_filter):
     for line_num, line in f.ChangedContents():
       for func_name, message, error in _BANNED_OBJC_FUNCTIONS:
         matched = False
@@ skipping 860 matching lines @@
           output_api,
           source_file_filter=lambda x: x.LocalPath().endswith('.grd')))
   results.extend(_CheckSpamLogging(input_api, output_api))
   results.extend(_CheckForAnonymousVariables(input_api, output_api))
   results.extend(_CheckCygwinShell(input_api, output_api))
   results.extend(_CheckUserActionUpdate(input_api, output_api))
   results.extend(_CheckNoDeprecatedCSS(input_api, output_api))
   results.extend(_CheckParseErrors(input_api, output_api))
   results.extend(_CheckForIPCRules(input_api, output_api))
   results.extend(_CheckForOverrideAndFinalRules(input_api, output_api))
+  results.extend(_CheckGNCheck(input_api, output_api))
 
   if any('PRESUBMIT.py' == f.LocalPath() for f in input_api.AffectedFiles()):
     results.extend(input_api.canned_checks.RunUnitTestsInDirectory(
         input_api, output_api,
         input_api.PresubmitLocalPath(),
         whitelist=[r'^PRESUBMIT_test\.py$']))
   return results
 
 
 def _CheckAuthorizedAuthor(input_api, output_api):
@@ skipping 393 matching lines @@
     builders.extend(['cros_x86'])
 
   # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
   # unless they're .gyp(i) files as changes to those files can break the gyp
   # step on that bot.
   if (not all(re.search('^chrome', f) for f in files) or
       any(re.search('\.gypi?$', f) for f in files)):
     builders.extend(['android_aosp'])
 
   return GetDefaultTryConfigs(builders)