Issue 697733002: Add a PRESUBMIT for gn check, currently only for //sky/*

Issue 697733002: Add a PRESUBMIT for gn check, currently only for //sky/* (Closed)

Created:
6 years, 1 month ago by eseidel

Modified:
6 years, 1 month ago

Reviewers:
jamesr

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add a PRESUBMIT for gn check, currently only for //sky/* Also fixed //sky/* to pass gn check again. This makes all of our previous DEPS header checking obsolete and those can be removed now. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e7473d7baa33d3f2a9d033b7dbf630ea03c15a8d

Patch Set 1 #

Patch Set 2 : Actually run the presubmit check #

Total comments: 3

Patch Set 3 : Now more amazing #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -1 line)			Patch
M	PRESUBMIT.py	View	1 2	2 chunks	+46 lines, -0 lines	0 comments	Download
M	sky/engine/wtf/BUILD.gn	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/services/inspector/BUILD.gn	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jamesr

lgtm https://codereview.chromium.org/697733002/diff/20001/PRESUBMIT.py File PRESUBMIT.py (right): https://codereview.chromium.org/697733002/diff/20001/PRESUBMIT.py#newcode417 PRESUBMIT.py:417: # TODO(eseidel): We should not have to pass ...

6 years, 1 month ago (2014-10-31 19:57:45 UTC) #4

eseidel

6 years, 1 month ago (2014-10-31 21:25:37 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
e7473d7baa33d3f2a9d033b7dbf630ea03c15a8d (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages