Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 697723003: Switch "html" Mojo modules to the Sky module system (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
esprehn, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Switch "html" Mojo modules to the Sky module system These never really worked with HTML imports. This CL updates them to use a more modern version of the Sky module system so we can delete the old this.exports pattern. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d7db5cf12426fdd591cdae8671194a942131ba39

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -179 lines) Patch
M mojo/public/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D mojo/public/html/BUILD.gn View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/public/html/convert_amd_modules_to_html.py View 1 chunk +0 lines, -99 lines 0 comments Download
A + mojo/public/sky/BUILD.gn View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/public/sky/convert_amd_modules_to_sky.py View 2 chunks +3 lines, -3 lines 0 comments Download
D mojo/public/tools/bindings/generators/js_templates/module.html.tmpl View 1 chunk +0 lines, -13 lines 0 comments Download
A + mojo/public/tools/bindings/generators/js_templates/module.sky.tmpl View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/mojom.gni View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator.gypi View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/inspector/inspector.sky View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/framework/shell.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/xmlhttprequest.sky View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/tests/services/buffer.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/services/codec.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/services/core.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/services/network.sky View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/viewer/BUILD.gn View 2 chunks +5 lines, -5 lines 0 comments Download
D sky/viewer/script/core.html View 1 chunk +0 lines, -3 lines 0 comments Download
A + sky/viewer/script/core.sky View 0 chunks +-1 lines, --1 lines 0 comments Download
D sky/viewer/script/support.html View 1 chunk +0 lines, -3 lines 0 comments Download
A + sky/viewer/script/support.sky View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-10-31 21:43:58 UTC) #1
esprehn
lgtm
6 years, 1 month ago (2014-10-31 21:46:03 UTC) #2
abarth-chromium
6 years, 1 month ago (2014-10-31 21:46:44 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d7db5cf12426fdd591cdae8671194a942131ba39 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698